@b4n requested changes on this pull request.

This looks great, and actually fixes some things on Linux as well, as e.g. default keybindings like <Primary>1 for custom commands didn't work before on the French layouts where 1 is <Shift>& (so one had to use <Primary><Shift>1). Nice!
I'm not very confident, but it might also help fixing some problems we had with Russian layouts on Windows? I'm afraid I remember something a lot more complicated had to be done, though.

However, we need an upgrade path for current keybindings from keybindings.conf, because right now it breaks any user-defined keybinding that is affected by the change – e.g. in my case <Primary><Shift>1 (which would now be <Primary>1), <Primary><Shift>greater (<Primary>greater), etc.

In src/keybindings.c:

>  {
-	guint state, keyval;
+	GdkModifierType consumed;
+	GdkKeymap *keymap = gdk_keymap_get_default();

ideally would use gdk_keymap_get_for_display(), probably on gdk_window_get_display(ev->window)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.