@b4n commented on this pull request.


In src/encodings.c:

>  			geany_debug("Couldn't convert from %s to UTF-8.", charset);
+			g_set_error(error, G_CONVERT_ERROR, G_CONVERT_ERROR_ILLEGAL_SEQUENCE,
+					_("Data contains NULs"));

Yes, if the conversion didn't fail (conv_error == NULL), it means the conversion was OK, but g_utf8_validate() failed, which can only happen on NULs if the data is otherwise UTF-8 (which it ought to be, unless there's a glaring bug in g_convert() yielding invalid data without reporting an error).


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3716/review/2013486389@github.com>