@elextr commented on this pull request.

In src/highlightingmappings.h:

> @@ -388,7 +388,12 @@ static const HLStyle highlighting_styles_CSS[] =
 	{ SCE_CSS_EXTENDED_IDENTIFIER,		"extended_identifier",		FALSE },
 	{ SCE_CSS_EXTENDED_PSEUDOCLASS,		"extended_pseudoclass",		FALSE },
 	{ SCE_CSS_EXTENDED_PSEUDOELEMENT,	"extended_pseudoelement",	FALSE },
-	{ SCE_CSS_MEDIA,					"media",					FALSE }
+	{ SCE_CSS_GROUP_RULE,				"group_rule",				FALSE },
+	/* In Geany 1.38 and earlier shipped filetypes.css with "media" identifier,
+	 * Scintilla/Lexilla 5.1.2 has renamed this style and extended its meaning.
+	 * We still recognize media for compatibility.
+	 */
+	{ SCE_CSS_GROUP_RULE,				"media",					FALSE }

yeah I think the second line needs to be removed so they are two separate syntactic entity names.

Basically I don't think its going to be possible to map the two together in the code as @kugel- wanted to, good try and it would have allowed old colour schemes to handle group_rule unchanged. But it looks like has to be done in the config file, and colour schemes.

Unless some new magic capability is added to highlightingmappings.h and highlighting.c to provide a backward compatibility feature, its always going to be a problem for colour schemes and filetype configs when syntactic entities change.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.