doesn't this break the use case of https://github.com/geany/geany/issues/2599?
No:
The file does not open (because the dialog is still open).
User says WHAT THE!!!! complete save as file opens User says WHAT THE!!!!
Which is exactly what happens now visually (but not behind the scenes), because the dialog is modal.