Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Hi, I'm working on updating the Geany package in nixpkgs from 1.38 to 2.0: NixOS/nixpkgs#265362.
With Geany 2.0, tests/test_sidebar.c fails on nixpkgs' automatic PR builder (ofborg) on macOS, but not on macOS locally - presumably due to the environment being headless in the former case. On Linux, test_sidebar succeeds both locally and on the builder. The issue would likely show up on Hydra as well, our central CI service, and would cause us to introduce workarounds that are probably avoidable.
The return value of gtk_init_check here is never examined. https://docs.gtk.org/gtk3/func.init_check.html says:
"Note that calling any GTK function or instantiating any GTK type after this function returns FALSE results in undefined behavior."
Could you please take a look at this? I can't really gauge what it would take to make the test run properly on Darwin in a headless environment (if possible). Worst case the test could skip itself and emit an appropriate message if GTK can't initialize, which would still be better than downstream having to explicitly work around it.
The build log for x86_64-darwin with the failing test can be viewed here. I attached it here in case that link becomes inaccessible: geany_2.0_x86_64-darwin_ofborg_buildlog.txt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.