@elextr commented on this pull request.

In ctags/gnu_regex/regex_internal.h:

> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const re_string_t *input, int idx,
 #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
 #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
 
-#ifdef WIN32
+#ifdef _WIN32

Just to summarise, since we have had several misunderstandings in this thread, resulting in a long conversation on a two line change:

for reasons presented above we will likely need to make the upgrade of this part of ctags at some point
that would normally mean we need to maintain changes (or upstream them) as queried at the start of the thread
but since upstream has already fixed the problem any upgrade will contain a fix, even if its not what we change, so we don't need to keep our two line fix or upgrade quickly
so since its a large upgrade making it at leisure when its actually needed is better than rushing it

@b4n conversation resolved?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.