@techee commented on this pull request.


In scripts/update-ctags.py:

> -        shutil.copy('parsers/' + f, dstdir + '/parsers/' + f)
-    elif os.path.exists(f):
-        shutil.copy(f, dstdir + '/parsers/' + f)
-    else:
-        print('Error: Could not find file ' + f + '!')
-        sys.exit(1)
+    shutil.copy(f, dstdir + '/parsers')
+
+os.chdir(dstdir + '/peg')
+peg_dst_files = glob.glob('*.c') + glob.glob('*.h')
+peg_dst_files = list(filter(lambda x: not x.startswith('geany_'), peg_dst_files))
+os.chdir(srcdir + '/peg')
+os.system('make -C {} peg/{}'.format(srcdir, ' peg/'.join(peg_dst_files)))
+print('Copying peg parsers... ({} files)'.format(len(peg_dst_files)))
+for f in peg_dst_files:
+    shutil.copy(f, dstdir + '/peg')

Since the code does more or less the same thing twice, it could be changed to something like the following:

os.chdir(srcdir + '/peg')
os.system('make -C {} peg/{}'.format(srcdir, ' peg/'.join(peg_dst_files)))
for dir in ['parsers', 'peg']:
    ...


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.