@b4n commented on this pull request.

LGTM from little review and testing apart from:

the comment about the patch file
the absence of tags parsing. the custom filetype version uses Java, which seems to do a decent job (beware that not knowing the language, I just copied a couple of samples and lanced at the results), should this one do the same?

In scintilla/scintilla_changes.patch:

> @@ -84,6 +84,7 @@ index cd4b23617..af4a73db4 100644
 +		&lmCPP,
 +		&lmCss,
 +		&lmD,
++		&lmDart,

As this isn't updating the chunk header, it's gonna corrupt the patch, isn't it?

In scintilla/scintilla_changes.patch:

> @@ -84,6 +84,7 @@ index cd4b23617..af4a73db4 100644
 +		&lmCPP,
 +		&lmCss,
 +		&lmD,
++		&lmDart,

…well OK, it's already broken since at least a9363bc, but is that an excuse? :)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.