@kugel- commented on this pull request.


In scintilla/gtk/ScintillaGTK.cxx:

> @@ -264,6 +279,12 @@ ScintillaGTK::~ScintillaGTK() {
 	}
 	ClearPrimarySelection();
 	wPreedit.Destroy();
+	if (settingsHandlerId) {
+		g_signal_handler_disconnect(settings, settingsHandlerId);
+	}
+	if (settings) {
+		g_object_unref(settings);

Fairly sure this is the problem. settings is initialized using gtk_settings_get_default() and this is documented as "transfer-none", so g_object_unref() is inappropriate. Code using this instance is then suffering from use-after-free.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.