@elextr commented on this pull request.


In doc/meson.build:

> @@ -0,0 +1,128 @@
+configure_file(input: 'geany.1.in',
+               output: 'geany.1',
+               install: true,
+               install_dir: join_paths(join_paths(prefix, get_option('mandir'), 'man1')),
+               configuration: cdata)
+
+if rst2pdf.found()
+    custom_target('pdf-manual',
+                   input: ['geany.txt'],
+                   output: ['geany-@0@.pdf'.format(cdata.get('VERSION'))],
+                   command: [rst2pdf, '@INPUT@', '-o', '@OUTPUT@'],
+                   build_by_default: true)
+endif
+
+tarball = run_command('test', '-f', 'geany.html')

@kugel- whilst its nice to support 18.04 as @eli-schwartz pointed out it is not longer the current LTS, but it is still in standard support until early next year. But since this PR is a forward looking maybe we can skip the last year of 18.04 and move to 20.04 which has Meson 0.54 IIUC (unless you need 18.04 yourself of course :-).

Also, it may not be idiomatic, but in subdirectory meson.builds I always use name = files("xxx") to give a name to any file in the subdir that I need outside the subdir, that handles source/build and paths and all that stuff :-)


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/2761/review/860383871@github.com>