@LiquidCake commented on this pull request.


In plugins/saveactions.c:

> +		ui_set_statusbar(TRUE, "%s", message);
+		g_warning("%s", message);
+		g_free(message);
+		g_free(new_filename);
+		return;
+	}
+
+	close(fd); /* close the returned file descriptor as we only need the filename */
+
+	doc->file_name = new_filename;
+
+	if (ft != NULL && ft->id == GEANY_FILETYPES_NONE)
+		document_set_filetype(doc, filetypes_lookup_by_name(default_ft));
+
+	/* force saving the file to enable all the related actions(tab name, filetype, etc.) */
+	document_save_file(doc, TRUE);

this method was re-used from Instantsave, which seems to need arbitrary file type setting.
Anyway im not re-using this code anymore - switched to document_save_file_as as you suggested. So Instantsave's code is left intact


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3911/review/2134275265@github.com>