Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@techee commented on this pull request.
In src/symbols.c:
> + if (sci_get_line_from_position(sci, pos_next) == line) + char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
Yeah, and what's the problem here? You would like to have the popup's right corner one character to the right? And how is it related to the shape of the caret?
Basically Scintilla internally always has caret between letters and only draws it over the next letter when for instance in a block mode (something I was fighting with in my vimode plugin because vi itself has caret on letters and sometimes this leads to some surprises in character number calculations). So caret over "e" in block mode is actually caret before "e".
But I still don't see the "wrongness" here - the popup jumps from the bottom-left corner of the block mode caret both when there is enough space on the right and also when there isn't and the popup is on the left, so nothing unexpected I'd say. Also this is a rare case where two conditions have to be met - not enough space and a block caret (and I never use overwrite mode, I just had to learn how to invoke "insert" on the mac :-).
But don't hesitate to implement it your way if this is something that bothers you :-).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.