@eli-schwartz commented on this pull request.


In meson.build:

> -if git.found()
+if git.found() and fs.is_dir('.git')
 	ret = run_command(git, 'rev-parse', '--short', '--revs-only', 'HEAD', check: true)
 	cdata.set_quoted('REVISION', ret.stdout().strip())
 else

I recommend to use fs.exists() since the .git filesystem entry can be a file, in which case the contents of the file are a single line:

gitdir: path/to/.git/worktrees/foobar

This is how git worktree works.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3578/review/1663643170@github.com>