Hi, this PR fixes this error spotted in Valgrind:

Invalid read of size 1
   at 0x49211F3: utils_get_initials (utils.c:775)
   by 0x48EBA56: load_dialog_prefs (keyfile.c:1025)
   by 0x48EBA56: read_config_file (keyfile.c:1258)
   by 0x48ED7C7: configuration_load (keyfile.c:1286)
   by 0x48EFBB7: load_settings (libmain.c:917)
   by 0x48EFBB7: main_lib (libmain.c:1154)
   by 0x5FC7CCF: (below main) (libc_start_call_main.h:58)
 Address 0xd21bfd1 is 0 bytes after a block of size 1 alloc'd
   at 0x4843788: malloc (vg_replace_malloc.c:442)
   by 0x5B26902: g_malloc (gmem.c:100)
   by 0x5B1BC2A: g_key_file_parse_value_as_string (gkeyfile.c:4310)
   by 0x5B1BD71: g_key_file_get_string (gkeyfile.c:1965)
   by 0x49213FF: utils_get_setting_string (utils.c:900)
   by 0x48EBA29: load_dialog_prefs (keyfile.c:1023)
   by 0x48EBA29: read_config_file (keyfile.c:1258)
   by 0x48ED7C7: configuration_load (keyfile.c:1286)
   by 0x48EFBB7: load_settings (libmain.c:917)
   by 0x48EFBB7: main_lib (libmain.c:1154)
   by 0x5FC7CCF: (below main) (libc_start_call_main.h:58)

I slightly reshaped utils_get_initials() to make it kinda more intuitive. It also got improved a bit, in that it now produces correct results when name begins with a space (which AFAICT doesn't really occur, but why not...)

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3844

Commit Summary

• c512f32 Fix read past end of string in utils_get_initials()

File Changes

(1 file)

• M src/utils.c (12)

Patch Links:

• https://github.com/geany/geany/pull/3844.patch
• https://github.com/geany/geany/pull/3844.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3844@github.com>