@nyamatongwe commented on this pull request.
@@ -1079,7 +833,7 @@
const Sci::Line lineStart = lineInsert;
// s may not NULL-terminated, ensure *ptr == '\n' or *next == '\n' is valid. - const char * const end = s + insertLength - 1; + const char *const end = s + insertLength - 1;
`CreateLoader` (the target of `this cast`) ***is*** a type-safety hole but that is just part of Scintilla's API being non-type-safe. So its OK for a linter to highlight that.
However, I can't see the link to `CellBuffer::BasicInsertString` where `end` is defined from the arguments. Maybe `s` is from some memory owned by the `Document` in the cast which is now questionable. If there isn't something more specific, with a trail of actions (like Clang analyze shows) or a stack trace, there isn't much that can be done.