Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
As mentioned ealier in this PR, it does NOT work on Windows and in the current state it will break the behavior for Windows users.
Huh? Windows should not change, it's still ifdef'd and uses
win32_open_browser()(which outright ignores the browser_cmd pref).
Sorry, I was very unclear in my post :(.
I assumed the TODO comment in the Windows code branch was meant to use the new code also on Windows and remove the previous code. This would be nice but won't work as gtk_show_uri_on_window doesn't work on Windows (as described).
Now, that we checked the new code won't work on Windows, we can happily merge this PR as is, maybe just remove the TODO comment in the Windows code branch.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.