This both reduces the amount of code (by more than ⅔!), and tries to move towards a state where new contributors don't feel like using manual keyfile read/write is the way to go (experience has shown the `load_dialog_prefs()` has a way of going unnoticed -- but @elextr will come up with a nice way of documenting this :wink:).
In theory it also reduce the possibility for typos leading to settings not being saved/loaded properly (i.e. if the setting name/group doesn't match), but as it's currently working it mostly allows for mistakes in the diff of this PR :smile: Though, I should have done that carefully enough to not risk too much. But review is of course a good idea (hint hint). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1184
-- Commit Summary --
* Port some settings to Stash * Port font settings to Stash * Port the long line settings to Stash * Port remaining visibility settings to Stash * Port tab position settings to Stash * Port remaining interface tab settings to Stash * Port remaining editor settings to Stash * Port remaining simple file settings to Stash
-- File Changes --
M src/keyfile.c (273) M src/prefs.c (331)
-- Patch Links --
https://github.com/geany/geany/pull/1184.patch https://github.com/geany/geany/pull/1184.diff