@rdipardo commented on this pull request.

In scintilla/src/CellBuffer.cxx:

> @@ -1079,7 +833,7 @@
 	const Sci::Line lineStart = lineInsert;
 
 	// s may not NULL-terminated, ensure *ptr == '\n' or *next == '\n' is valid.
-	const char * const end = s + insertLength - 1;
+	const char *const end = s + insertLength - 1;

Pesky bot.

If anyone has 12 GB of RAM to spare and at least 8 cores, you can run the analyzers locally like this:

set -e

CODEQL="$(command -v codeql)" || CODEQL='../codeql-cli/codeql/codeql'
[ -x "$CODEQL" ] ||\
  {
    CODEQL_CLI="$(dirname "$0")/codeql-linux64.zip" &&\
    curl -SJL 'https://github.com/github/codeql-cli-binaries/releases/download/v2.20.0/codeql-linux64.zip' -o "$CODEQL_CLI" &&\
    unzip  -q "$CODEQL_CLI" -d "$(dirname "$0")/codeql-cli";
  }

[ -d "$(dirname "$0")/codeql" ] ||\
  git clone 'https://github.com/github/codeql.git' "$(dirname "$0")/codeql"

[ -n "$1" ] && DATABASE="$1" || DATABASE="$(dirname "$0")/geany-codeql-db"
[ -n "$2" ] && CODEQL_DIR="$2" || CODEQL_DIR="$(dirname "$0")/codeql"
[ -n "$3" ] && BUILD_ROOT="$3" || BUILD_ROOT='_build'

[ -d "$DATABASE" ] ||\
  {
    NOCONFIGURE=1 ./autogen.sh                            &&\
    mkdir -p "$BUILD_ROOT" "$BUILD_ROOT"/share/geany      &&\
    pushd "$BUILD_ROOT"                                   &&\
    CFLAGS='-g -O0' \
    ../configure --prefix="$(pwd)" \
            --exec-prefix="$(pwd)" \
            --with-geany-libdir="$(pwd)/src/.libs" \
            --disable-html-docs \
            --disable-pdf-docs \
            --disable-api-docs \
            --disable-gtkdoc-header \
            --enable-binreloc=no                          &&\
    # only full builds can be analyzed
    make clean && popd                                    &&\
    $CODEQL database create "$DATABASE" --language=c-cpp --source-root="$BUILD_ROOT" --command="make -j8" --overwrite;
  }

CONFIG="$CODEQL_DIR/cpp/ql/src/codeql-suites/cpp-security-and-quality.qls"
$CODEQL database analyze "$DATABASE" --output="/tmp/$(basename "$DATABASE")" "$CONFIG" --format=csv --threads=0 --download

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.