How do you think so? AFAIK the lookup is made solely on the string itself. Either it matches or not.

Oh, I thought it was possible to have the same string at different places in the program with differing translations? If not by file/line how is that done? (translation newby question)

AFAIK this is not possible. If so, then there is some special syntax or so. Usually, the lookup is done based only on the string.
Example for the string "Templates" used in here:

#: data/geany.glade:5527 src/prefs.c:1625 src/templates.c:325
msgid "Templates"
msgstr ""

As you can see the translation item has the multiple code occurrences listed as comment.

Maybe @frlan knows better.

Did I say it would break anything? Just that the strings would be untranslated, and even if all cases of the same string have the same translations[...]

I meant "break" in terms of "new untranslated strings which would break the string freeze". Sorry, it wasn't the best wording.

do "Templates" or "Files" occur in the UI anywhere already?

Yes, see the example above.

I'm not sure what the point of running update PO is, we don't do that for each PR.

I suggested this so one can test whether the added strings here will be translated or not to stop us speculating whether or not it will have an effect.
To get this further, I just did it myself: applied the patch, ran make -C po update-po, checked the re-generated translation files, there are no new untranslated strings, ran Geany with a non-English locale and saw that the new menu items got properly translated by the already existing translations for "Template" and "Files".

That was done at string freeze and will not have these strings in it, so they will not be translated thats all.

This isn't the case, see above.
I wonder why we discuss this so long with much guessing what might happen instead of just testing it to get sure :(.

I don't understand what does this mean? :).

There are changes to geany.txt included in this PR, so I expected they were the documentation associated with this change. But weirdly the documentation changes do not use either of the words Templates or Files so I'm not sure how they document the new menu entries ;-)

To me the changed parts in the documentation are related to the feature.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.