@b4n now that you are returning nullptr from pixels() but you did not put a check for that on the return value of every use of pixels() all you have done is shift the problem. 😜

Not really: at least to the C guy I am, reading 0 bytes from nullptr or 0 bytes from a valid pointer doesn't seem much different.

What I meant is that you are assuming that wherever the return pointer from Pixels() is used its not de-referenced for any reason, otherwise its a segfault or a UB. I haven't traced all uses of the pointer Pixels() function returns to see, I just noticed your patch had no checks of the returned pointer.

Are you gonna post to Scintilla?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.