@eht16 commented on this pull request.


In scripts/ci_mingw64_geany.sh:

> +	log "Signing Geany binary files"
+	for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do
+		for binary_file in $(ls ${binary_file_pattern}); do
+			sign_file ${binary_file}
+		done
+	done
+}
+
+
+convert_text_files_to_crlf() {
+	log "Converting line endings to CRLF in text files"
+	for text_file_pattern in ${GEANY_RELEASE_TEXTFILE_PATTERNS[@]}; do
+		for text_file in $(ls ${text_file_pattern}); do
+			mime_type=$(file --brief --mime-type ${text_file})
+			case $mime_type in text/*)
+				unix2dos ${text_file}

Thanks for creating the issue and the investigation.
Nice that Notepad now can handle non-CRLF line endings. This was the main reason I convert the line endings.

So I just removed the code from the build script here and in the G-P counterpart.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3315/review/1212689567@github.com>