Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
As we all know I'm not @b4n and I'm sure nobody is as good as he is in reviewing such things but anyway I gave this PR a test and review and it looks very good!!
Oh, and please don't take this as an application for becoming the next tagmanager expert :D.
Thank you so much @techee for this hard work. Much appreciated.
I got a few rather harmless compiler warnings:
tm_parser.c: In function ‘tm_parser_get_sidebar_info’:
tm_parser.c:1087:19: warning: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Wsign-compare]
1087 | if (group >= map->group_num)
| ^~
tm_parser.c:1081:15: warning: unused variable ‘i’ [-Wunused-variable]
1081 | guint i;
| ^
Easy enough I guess.
At top level:
tm_parser.c:74:25: warning: ‘map_C_old_parser’ defined but not used [-Wunused-variable]
74 | static TMParserMapEntry map_C_old_parser[] = {
| ^~~~~~~~~~~~~~~~
map_C_old_parser is used for Ferite and GLSL according to its comment. Ferite is gone and GLSL used the normal C parser, so I guess this whole map entry can be removed?
Apart from that, I'd suggest to merge this soon to get more real life testing (I use master for daily work).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.