b4n requested changes on this pull request.
Looks pretty good but * ABC parser might be useful, as mentioned in the previous comment; * Some parsers removed because they are using RE which doesn't work anymore might still be useful, and we should find a solution for this…
@@ -3484,3 +3484,8 @@ extern void verbose (const char *const format, ...)
{ } /* GEANY DIFF END */ + +extern bool canUseLineNumberAsLocator (void) +{ + return (Option.locate != EX_PATTERN); +}
missing newline
{
- const kindOption *kindOpt; - - if (hasRegexKind (language, kind)) - return isRegexKindEnabled (language, kind); - else if (hasXcmdKind (language, kind)) - return isXcmdKindEnabled (language, kind);
Willn't this be still relevant for RE if we still keep it in the end?
@@ -2742,8 +2793,12 @@ extern void anonGenerate (vString *buffer, const char *prefix, int kind)
vStringCopyS(buffer, prefix);
- unsigned int uHash = anonHash((const unsigned char *)getInputFileName()); - sprintf(szNum,"%08x%02x%02x",uHash,lang -> anonumousIdentiferId, kind); +/* GEANY DIFF */ +/* unsigned int uHash = anonHash((const unsigned char *)getInputFileName()); + sprintf(szNum,"%08x%02x%02x",uHash,lang -> anonumousIdentiferId, kind); */ + sprintf(szNum,"%u", lang -> anonumousIdentiferId);
Why did you change this? The upstream anon ID logic seems more stable and unique, and I don't really see a problem with it?