@eht16 commented on this pull request.
@@ -388,7 +388,12 @@ static const HLStyle highlighting_styles_CSS[] =
{ SCE_CSS_EXTENDED_IDENTIFIER, "extended_identifier", FALSE }, { SCE_CSS_EXTENDED_PSEUDOCLASS, "extended_pseudoclass", FALSE }, { SCE_CSS_EXTENDED_PSEUDOELEMENT, "extended_pseudoelement", FALSE }, - { SCE_CSS_MEDIA, "media", FALSE } + { SCE_CSS_GROUP_RULE, "group_rule", FALSE }, + /* In Geany 1.38 and earlier shipped filetypes.css with "media" identifier, + * Scintilla/Lexilla 5.1.2 has renamed this style and extended its meaning. + * We still recognize media for compatibility. + */ + { SCE_CSS_GROUP_RULE, "media", FALSE }
Though it doesn't work, easy to find out by just testing it:
I thought it did work, but maybe I tested it wrong, I just tried some CSS of the web :-)
Or I tested it wrong? We need a third tester :D.
For 4. if there is both a `media` and a `group_rule` syntactic entity is it possible they could both be assigned the same named style in the config file without any extra code needed?
For me, it didn't work. I tested with the snippet I posted above in `~/.config/geany/filedefs/filetypes.css` and got "Bad color 'group_rule'" in the debug log.