Just another remark. I took a quick look at gedit. Their info bar has two buttons: "Reload" and "Ignore". The buffer is also unmodifiable. After I press Ignore and tried to save I got another info bar with buttons: "Save anyway" and "Don't save". (That was basically my very first point. But, you explained why gedit and geany behaviors are different ) However, if you found that the result is in fact "terrible", no problem, we definitely can leave everything as is.
On Tue, Oct 30, 2018 at 10:53 PM Yury Dubinsky yury.dubinsky@gmail.com wrote:
Well, just one more remark. Currently after the Info bar appears the buffer becomes unmodifiable.So, we can't do anything with the content until we make a decision. Isn't it?
On Tue, Oct 30, 2018 at 5:39 PM elextr notifications@github.com wrote:
No, "Undecided" is not a good button label. I suggested it as a way to try to gently imply that I thought the whole thing was getting silly. Sorry that you took it seriously.
Info bars are meant to convey information that is important but not urgent, it does not need immediate resolution. So info bars deliberately do not stop normal operations, unlike dialogs which must be actioned immediately. Thats why the file change notification was moved from a dialog to an info bar. The fact that the file on disk has changed does not need to be actioned immediately, the info bar does not need to be dismissed, editing can continue and the bar remains as a reminder. So info bars should not occupy large amounts of screen space and by that criteria I am afraid the result is in fact "terrible".
The button label "Cancel" is the standard GUI button label for "close and do nothing" so that is what that button should be (in English anyway).
Since info bars do not block the user interface (unlike dialogs) the user is not restricted to just the options the info bar provides. So there is no need to provide copious options on the info bar. As @codebrainz https://github.com/codebrainz pointed out you still have access to the normal features of the application. For example, in the case of an unexpected file change notification a user could decide to load the changed file into another buffer to look at it, see what changed, and decide what to do. The info bar does not need a "Load file into another buffer" button to allow them to do that.
The info bar should only have "Cancel" and maybe the most common operation available as a convenience.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/geany/geany/issues/1885#issuecomment-434479890, or mute the thread https://github.com/notifications/unsubscribe-auth/Al5v5M8yzmmKBGNlxkUU3aSbklH-PxPuks5uqMcJgaJpZM4UsYx0 .