@scresto09 commented on this pull request.


In incdec/src/incdec-plugin.c:

> +
+		/* when the number changes sign, the format is reset to avoid a display shift */
+		if ((positive == FALSE && guessed_number >= 0) || (positive == TRUE && guessed_number < 0))
+		{
+			format_length = 0;
+		}
+		else
+		{
+			format_length = digit_end - digit_start;
+			if (format_length > 12)
+				format_length = 0;
+		}
+
+		g_snprintf(format_buf, sizeof(format_buf)-1, "%%0%d%c", format_length, use_hexa ? ( hexaCase == HEXA_CASE_UPPER ? 'X' : 'x' ) : 'd');
+
+		if ((buf = g_strdup_printf(format_buf, guessed_number)))

Hum, the code seems correct to me, and it’s really useful for me to use a format that isn’t a "string literal".
I don’t think this is a problem. If you'd like, maybe I could add a DEFINE or a CFLAGS to disable this warning ?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany-plugins/pull/1351/review/2572796831@github.com>