Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@elextr commented on this pull request.
In src/document.c:
> if (main_status.main_window_realized) - dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename); + dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg); + + ui_set_statusbar(TRUE, "%s", warn_msg);
Oh, its only on the declaration, I looked at the definition, ok.
which I use in the patch.
which patch?
My point was that ui_set_statusbar printfs the input then calls msgwin_status_add with %s to re-printf the result string that it just printfed ((mis)using printf as a verb), so maybe that should use msgwin_status_add_string()?
12 out of 87 calls pass "%s"
Not inconsiderable. In this case you need to printf the string before sending it to the status bar because it is used in the dialog, but since status bar is always doing GTK with the result the cost of re-printfing possibly is immaterial.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.