The indented #command_example(); in

[…]

isn't a valid conf file line as # should be placed at the beginning of the line. This makes Scintilla to render #command_example(); as if it weren't a comment. This patch changes this to

Actually it is valid for our purpose at least.

This makes Scintilla to render #command_example(); as if it weren't a comment.

Yeah that's not very nice indeed, so it'd be indeed good to stick to what that lexers accepts as a comment. However, we explicitly set lexer.props.allow.initial.spaces=0 in filetypes.conf, which we probably shouldn't… setting it to 1 also fixes the highlighting in this file.

For history, the property originates from 00bc23c, which commit message confuses me, as I understand it as meaning the exact contrary to what it actually does…

It's however worth noting that the tag parser ignores lines starting with a space regardless of what comes after, e.g. key=value isn't parsed as a key-value pair.

I'm not saying we shouldn't apply your changes here, they do look better to me. I'm just trying to be (too) thorough.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.