@kugel- requested changes on this pull request.


In src/highlightingmappings.h:

>  	{ SCE_P_FCHARACTER,		"fcharacter",		FALSE },
-	{ SCE_P_FTRIPLE,		"ftriple",			FALSE },
-	{ SCE_P_FTRIPLEDOUBLE,	"ftripledouble",	FALSE },
+	{ SCE_P_FTRIPLE,		"ftriple",		FALSE },
+	{ SCE_P_FTRIPLEDOUBLE,		"ftripledouble",	FALSE },
+	{ SCE_P_ATTRIBUTE,		"fattribute",		FALSE },

fattribute -> attribute, or is this intention?


In src/highlighting.c:

> @@ -1436,7 +1436,8 @@ gboolean highlighting_is_string_style(gint lexer, gint style)
 				style == SCE_P_FCHARACTER ||
 				style == SCE_P_FTRIPLE ||
 				style == SCE_P_FTRIPLEDOUBLE ||
-				style == SCE_P_STRINGEOL);
+				style == SCE_P_STRINGEOL ||
+				style == SCE_P_ATTRIBUTE);

If I understand the usage in LexPython.cxx correctly then this new style is totally not a string, It seems to refer to Python class attributes, i.e. this is more of an identifier like class members.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3292/review/1109834134@github.com>