When the plugin Numbered Bookmarks is switched on, Geany crashes instantly on start-up. Running GDB shows the following warning:
Program received signal SIGSEGV, Segmentation fault.
0x00007fffd153f2f4 in SetMarker (sci=0x9fa4a0, bookmarkNumber=1, markerNumber=2, line=247) at geanynumberedbookmarks.c:885
885 fd=GetFileData(document_get_current()->file_name);
I assume that at start-up the call <b>document_get_current()</b> will return a NULL pointer? And asking a <b>file_name</b> member will cause a segfault?
Tested on geany-plugins commit 4c1137373f78bd13df9ee46c10876a3142675573 of Nov. 8th, 2015.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/301
Yeah and by the way using the old->new order would mean that the old filetype definitions could be read forever (unless the user explicitly deletes them) and the updated definitions in new Geany releases would be ignored.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/485#issuecomment-154882288
@b4n OK, I think I misunderstood your original post, I thought you meant reading new first, old second (and it's the other way round).
I think exceptions like this make things more confusing for users at the end. And after the patch things will work the same way as before for the "misbehaving" users - their updated filetypes won't be read (previously they were overwritten during the installation, after the patch they will be read from a different location). The new location should be mentioned in the release notes so people who need to update file definitions in the system directory know the new location.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/485#issuecomment-154881928
Changes
- Ensured consistency by ending every line with a semicolon
- Added two MathML file-extensions (*.mml and *.mathml;) to "XML="
Justification for proposed changes
- Code consistency is important in programming
- MathML is a form of XML that is commonly used and is part of the HTML5 standard
- W3 MathML Specification: http://www.w3.org/TR/MathML3/
- Geany properly highlights the code when the MathML file-extension is recognized
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/731
-- Commit Summary --
* Update filetype_extensions.conf
-- File Changes --
M data/filetype_extensions.conf (8)
-- Patch Links --
https://github.com/geany/geany/pull/731.patchhttps://github.com/geany/geany/pull/731.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/731