> @@ -0,0 +1,15 @@
> +if ENABLE_COMMANDER
> +geanyplugins_LTLIBRARIES += %D%/commander.la
> +
> +%C%_commander_la_SOURCES = %D%/commander-plugin.c
> +%C%_commander_la_CPPFLAGS = $(AM_CPPFLAGS) \
> + -DPLUGIN=\"commander\" \
> + -DG_LOG_DOMAIN=\"Commander\"
> +%C%_commander_la_CFLAGS = $(AM_CFLAGS) \
> + $(COMMANDER_CFLAGS)
> +%C%_commander_la_LIBADD = $(COMMONLIBS) \
> + $(COMMANDER_LIBS)
> +
> +endif
> +
> +%C%_commander_la_SHORTNAME = commander_la
this most probably should be set for all plugins, it's too easy to miss when adding plugin-specific `CFLAGS`, especially as the difference is quite subtle. Though OK, it's not *that* important, only means building in different directories doesn't generate the same-named object files, but that'd still be annoying.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277/files#r46149869
> - ao_wrapwords.h \
> - ao_copyfilepath.h \
> - addons.c \
> - ao_blanklines.c \
> - ao_doclist.c \
> - ao_openuri.c \
> - ao_systray.c \
> - ao_bookmarklist.c \
> - ao_markword.c \
> - ao_tasks.c \
> - ao_xmltagging.c \
> - ao_wrapwords.c \
> - ao_copyfilepath.c
> -
> -addons_la_LIBADD = $(COMMONLIBS)
> -
> include $(top_srcdir)/build/cppcheck.mk
Sorry, I can't follow (I never use make check). Are you saying that, for example, "make -C addons check" should invoke "make check" in the top-level Makefile? And how did I change make check behavior?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277/files#r46149268
> - ao_wrapwords.h \
> - ao_copyfilepath.h \
> - addons.c \
> - ao_blanklines.c \
> - ao_doclist.c \
> - ao_openuri.c \
> - ao_systray.c \
> - ao_bookmarklist.c \
> - ao_markword.c \
> - ao_tasks.c \
> - ao_xmltagging.c \
> - ao_wrapwords.c \
> - ao_copyfilepath.c
> -
> -addons_la_LIBADD = $(COMMONLIBS)
> -
> include $(top_srcdir)/build/cppcheck.mk
This is not acceptable, `make check` has to behave the same everywhere -- and especially, it has to run the checks when called from the top-level as it used to, so it's run by e.g. `make distcheck`. AFAICS, it doesn't.
I guess a possible solution would be to "simply" populate a variable like i.e. `CPPCHECK_DIRS` and have that in the top-level Makefile's cppcheck rule instead of `$(srcdir)` or something.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277/files#r46148966
> @@ -0,0 +1,16 @@
> +include %D%/src/Makefile.rel.am
> +
> +if ENABLE_ADDONS
> +addonsdocdir = $(docdir)/addons
> +dist_addonsdoc_DATA = \
> + %D%/README \
> + %D%/ChangeLog \
> + %D%/NEWS \
> + %D%/COPYING \
> + %D%/AUTHORS
I don't really like how this got duplicated a lot… unfortunately I don't have a solution for that as we can't rely on something like `$(plugin)` anymore as it would conflict in the top-level Makefile
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277/files#r46147828