Solves #3556.
This PR:
1. Replaces yyyy/mm/dd format in "Edit > Insert date" with yyyy-mm-dd (which happens to be the recommended format in ISO 8601), and mm.dd.yyyy with mm/dd/yyyy (using slashes seems to be more common for that date format), leaving dd.mm.yyyy as is (with dots).
2. Updates all the translation files accordingly (e.g., `es.po` currently translates the string `yyyy/mm/dd` to `aaaa/mm/dd`; this needed to be updated as well).
3. Sets yyyy-mm-dd as the default (first option in "Insert date", default custom date format, and also uses it in "Date & time" under Edit > Preferences > Templates, which is currently using inconsistent date formats).
I have split this PR into three commits for convenience, just in case the devs don't want to pull all of it. _(For example, I understand that @frlan is currently fidgeting with the translations and maybe doesn't want to pull the commit that touches them.)_
Feel free to squash them if preferred.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3570
-- Commit Summary --
* Use ISO format yyyy-mm-dd instead of yyyy/mm/dd
* Update translations with new date format
* Make yyyy-mm-dd the primary date format
-- File Changes --
M po/ar.po (16)
M po/ast.po (16)
M po/be.po (16)
M po/bg.po (16)
M po/ca.po (16)
M po/cs.po (16)
M po/da.po (16)
M po/de.po (16)
M po/el.po (16)
M po/en_GB.po (16)
M po/es.po (16)
M po/et.po (16)
M po/eu.po (16)
M po/fa.po (16)
M po/fi.po (16)
M po/fr.po (16)
M po/gl.po (16)
M po/he.po (16)
M po/hi.po (8)
M po/hu.po (16)
M po/id.po (16)
M po/ie.po (16)
M po/it.po (16)
M po/ja.po (16)
M po/kk.po (16)
M po/ko.po (16)
M po/ku.po (16)
M po/lb.po (16)
M po/lt.po (16)
M po/lv.po (16)
M po/mn.po (16)
M po/nl.po (16)
M po/nn.po (8)
M po/pl.po (16)
M po/pt.po (16)
M po/pt_BR.po (16)
M po/ro.po (16)
M po/ru.po (16)
M po/si.po (8)
M po/sk.po (16)
M po/sl.po (16)
M po/sr.po (16)
M po/sv.po (16)
M po/tr.po (16)
M po/uk.po (16)
M po/vi.po (16)
M po/zh_CN.po (16)
M po/zh_TW.po (16)
M src/templates.h (2)
M src/ui_utils.c (26)
-- Patch Links --
https://github.com/geany/geany/pull/3570.patchhttps://github.com/geany/geany/pull/3570.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3570
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3570(a)github.com>
Please could **Geany** highlight the **var** keyword in Java?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3854
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3854(a)github.com>
I want geany to allow me to colorize files with this hashbang by default as sh.
```cs
#!/bin/busybox ash
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3884
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3884(a)github.com>
Created a project. Added a header and source file. Closed project. Always have to re add source files after closing project.
Was wondering if this is normal or a problem with my computer.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3212
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3212(a)github.com>
Steps to reproduce:
1. With no project open, open some files
2. Open project A
3. Without closing project A first, open project B
4. Close project B
5. The originally open files from (1) are gone
Note that simple
1. With no project open, open some files
2. Open project A
3. Close project A
restores the session correctly.
I was wondering whether some of the session-split patches caused this but I checked out Geany 1.35 and it contained the same bug. I haven't investigated more so far.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3897
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3897(a)github.com>
Steps to reproduce:
1. With no project open, open some files
2. Open project A
3. Without closing project A first, open project B
4. Close project B
5. The originally open files from (1) are gone
The problem is that when project A closes and all its files are closed, load_config() gets called which contains
configuration_save_default_session();
This saves the session with all files closed and replaces the original session.
This patch modifies the code to call configuration_save_default_session() only when there are some open tabs so the above problem gets solved.
Even though I was worried that this would break saving default session when all its files get closed and then a project is loaded, it doesn't seem to be the case (I haven't investigated deep enough why).
An alternative to this approach would be to pass a boolean as a parameter of quite many functions and propagate the information whether project close preceded its opening but it introduces a much bigger diff and makes the complicated session opening stuff even wilder.
Fixes #3897.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3898
-- Commit Summary --
* Fix a problem when multiple project opens clear the default session
-- File Changes --
M src/project.c (3)
-- Patch Links --
https://github.com/geany/geany/pull/3898.patchhttps://github.com/geany/geany/pull/3898.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3898
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3898(a)github.com>
From having a look at where this function is used, by Geany it's used only to store configuration files in the .config directory and some auxiliary functions like writing the export file by the exporter plugin. In the geany-plugins project this function is used only for saving configuration files.
Before this patch, the fwrite() method was used by default for saving configuration files (because g_file_replace_contents() normally used by Geany wasn't used in this function) which wasn't very safe and could lead to configuration file loss under some extreme conditions.
The documentation of this function was changed to reflect the situation better than now - the previous comment made the impression that file permissions were always preserved with this method but it wasn't the case and depended on the exact configuration.
Replaces #3947.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3950
-- Commit Summary --
* Modify utils_write_file() to always use g_file_replace_contents()
-- File Changes --
M src/utils.c (69)
-- Patch Links --
https://github.com/geany/geany/pull/3950.patchhttps://github.com/geany/geany/pull/3950.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3950
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3950(a)github.com>
Github actions can do Linux (Ubuntu 16.04, 18.04 and 20.04) and windows and OSX Catalina and Big Sur so testing could check all platforms.
This is a placeholder issue, not sure what is _actually_ involved, but somebody who knows might replace this with a checklist.
PS IIUC github actions can run docker so the @eht16 one could be used maybe?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2671