According to b0b0ebb469a6b7eb74d321e6f5d7fe6f0bfcf6ba we guard against proxying the widget more than once for some Windows reasons, but this breaks the case where the same GeanyEntryAction has to re-create a fresh proxy, like when moving the item around.
So, move the guard value to the proxied widget, not the action.
Fixes #3831.
As this is Windows-related (see b0b0ebb469a6b7eb74d321e6f5d7fe6f0bfcf6ba), it could be nice if somebody could actually check that this patch doesn't break anything there. I likely won't, at least in a yearly manner.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3838
-- Commit Summary --
* Fix search entry after editing the toolbar
-- File Changes --
M src/geanyentryaction.c (6)
-- Patch Links --
https://github.com/geany/geany/pull/3838.patchhttps://github.com/geany/geany/pull/3838.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3838(a)github.com>
The Help command does not work on my Linux Mint 21 system, because BROWSER env variable is not set so `sensible-browser` does nothing. At minimum, the Help command should report an error when the return value is non-zero.
However, my system does have a preferred browser set to firefox - I'm not sure if this is part of a (freedesktop.org?) standard. Ideally Geany would use that as the default browser tool. Or is that moving to $BROWSER instead?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3468
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3468(a)github.com>
settings in filetypes.pascal:
```
[settings]
tag_parser=Pascal
lexer_filetype=Pascal
```
I try to improve pascal lexer with class and function name hightlighting (in LexCPP named "Global classes and typedefs"). For that geany tagger has to fill a wordlist with keys found by tagging function (see ctags/parsers/pascal.c)
In general parser seems to work sucessfully, because sidebar is updated correctly, which means function names can be seen there (`sidebar_update_tag_list works` o.k.).
On the other hand, if I attach debug code to `document.c:document_highlight_tags` function to see result of call of `symbols_find_typenames_as_string` always an empty string is returned.
Diving deeper in the code, I see whithin `symbols_find_typenames_as_string`, `typedefs->len`is always zero, which means `app->tm_workspace->global_typename_array` is not filled correctly.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3848
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3848(a)github.com>
Hi, this PR fixes this error spotted in Valgrind:
```
Invalid read of size 1
at 0x49211F3: utils_get_initials (utils.c:775)
by 0x48EBA56: load_dialog_prefs (keyfile.c:1025)
by 0x48EBA56: read_config_file (keyfile.c:1258)
by 0x48ED7C7: configuration_load (keyfile.c:1286)
by 0x48EFBB7: load_settings (libmain.c:917)
by 0x48EFBB7: main_lib (libmain.c:1154)
by 0x5FC7CCF: (below main) (libc_start_call_main.h:58)
Address 0xd21bfd1 is 0 bytes after a block of size 1 alloc'd
at 0x4843788: malloc (vg_replace_malloc.c:442)
by 0x5B26902: g_malloc (gmem.c:100)
by 0x5B1BC2A: g_key_file_parse_value_as_string (gkeyfile.c:4310)
by 0x5B1BD71: g_key_file_get_string (gkeyfile.c:1965)
by 0x49213FF: utils_get_setting_string (utils.c:900)
by 0x48EBA29: load_dialog_prefs (keyfile.c:1023)
by 0x48EBA29: read_config_file (keyfile.c:1258)
by 0x48ED7C7: configuration_load (keyfile.c:1286)
by 0x48EFBB7: load_settings (libmain.c:917)
by 0x48EFBB7: main_lib (libmain.c:1154)
by 0x5FC7CCF: (below main) (libc_start_call_main.h:58)
```
I slightly reshaped `utils_get_initials()` to make it kinda more intuitive. It also got improved a bit, in that it now produces correct results when `name` begins with a space (which AFAICT doesn't really occur, but why not...)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3844
-- Commit Summary --
* Fix read past end of string in utils_get_initials()
-- File Changes --
M src/utils.c (12)
-- Patch Links --
https://github.com/geany/geany/pull/3844.patchhttps://github.com/geany/geany/pull/3844.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3844
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3844(a)github.com>
Fix utils_get_initials() reading past the end of the input string if that string was empty.
Also fix support for non-ASCII initials for which the UTF-8 character representation would have been truncated to the first byte only, leading to an invalid value.
The implementation here also tries to handle combining accents, although that part might not be really solid.
Fixes #3844.
---
This might get a bit over-the-top with the support for non-composable combining marks, but well, now it's there? :)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3846
-- Commit Summary --
* Fix invalid memory access and Unicode support in utils_get_initials()
-- File Changes --
M src/utils.c (42)
M tests/test_utils.c (23)
-- Patch Links --
https://github.com/geany/geany/pull/3846.patchhttps://github.com/geany/geany/pull/3846.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3846
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3846(a)github.com>
On need to edit, modify the 'black scheme', tried to open the file but have no idea where the Windows' Geany's color scheme is saved
as in **Users/....geany** setting directory , `colorscheme` dir. is empty, while (almost) all file settings else are available
Please help out!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/issues/72
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-themes/issues/72(a)github.com>
Properly display the module node itself in the symbols tree so it can be the module content's parent instead of having each content node showing the module name as prefix.
Fixes #2650.
This is a revamp of the old patch I suggested ages ago in #2650 but failed to PR/commit.
@fbrau can you test this and see if all is good for you?
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3837
-- Commit Summary --
* Erlang: display module node in the symbols tree
-- File Changes --
M src/tagmanager/tm_parser.c (3)
M tests/ctags/maze.erl.tags (2)
M tests/ctags/test.erl.tags (2)
-- Patch Links --
https://github.com/geany/geany/pull/3837.patchhttps://github.com/geany/geany/pull/3837.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3837
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3837(a)github.com>
This happens with erlang files, just erlang files
Im on 1.37. If im not wrong, this didnt happened on 1.36...
It looks (erlang file):
It should look (python file):
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2650
After moving the search bar in the Customize Toolbar dialog, it will no longer do anything when typing in the entry. Possibly related to this code:
```c
static void geany_entry_action_connect_proxy(GtkAction *action, GtkWidget *widget)
{
GeanyEntryActionPrivate *priv = GEANY_ENTRY_ACTION_GET_PRIVATE(action);
/* make sure not to connect handlers twice */
if (! priv->connected)
if (priv->numeric)
g_signal_connect(priv->entry, "insert-text",
G_CALLBACK(ui_editable_insert_text_callback), NULL);
g_signal_connect(priv->entry, "changed", G_CALLBACK(delegate_entry_changed_cb), action);
g_signal_connect(priv->entry, "activate", G_CALLBACK(delegate_entry_activate_cb), action);
g_signal_connect(priv->entry, "activate-backward",
G_CALLBACK(delegate_entry_activate_backward_cb), action);
priv->connected = TRUE;
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3831
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3831(a)github.com>
Hi all.
I'd say I qualify with a frequent and happy Geany user, as I just love that IDE — been my favourite for nearly two decades now.
The issue I have is somewhat annoying and describes as follows:
* Enable the VTE in Geany preferences
* In Geany additions preferences, enable " _Enclose selection automatically without requiring a shortcut_ "
* Select some text in the editor
* Switch to the VTE and type a command that requires quoting, parentheses or braces
**What happens**: the previously selected text is enclosed with the first enclosing character that occurred while typing in the VTE instead of being silently eaten, as one would expect.
I use the VTE on a regular basis and I found myself accepting to watch out for any selection before I use the VTE. But despite my efforts I fail and I think that's to be expected, as a human :-D .
*DISCLAIMER: I don't know if it's a VTE issue, a plugin issue, a geany issue or a GTK issue; I needed to start somewhere so I submit it here.* Be free to dispatch it at will to the right audience if that's necessary. And if *I* need to do that, I will, no wuckers. Just orient me.
As for the techno stuff, before you ask: I'm running Geany on Manjaro. My current version is **1.38-2** "_Sulamar_" and plugins are version **1.38-3**. The issue I described has existed for as long as I can remember.
I'd like to thank the community for providing such a great, bloat-free tool, a breathe compared to the usual monsters, IMHO. May the Geany remain out the bottle for a long, long time.
ℼ
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1181
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/issues/1181(a)github.com>