It seems that GDK_MOD2_MASK isn't the right modifier to check for
command pressed - its mapping is platform-specific and while this works
on macOS, it has undesirable side-effects on linux. Use GDK_META_MASK
instead which based on my testing seems to do the right thing both on
macOS and linux.
Fixes (1) in #1136
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1141
-- Commit Summary --
* vimode: fix escape not working when numlock is on
-- File Changes --
M vimode/src/keypress.c (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1141.patchhttps://github.com/geany/geany-plugins/pull/1141.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1141
I'm surprised there isn't already an issue for this, but I can't find it, better googlers may.
The python checks and commands used in the build need updating to python3. The `python` command does not exist on many systems now.
1. `configure.ac` checks for `python` so the docs have to be disabled here, even though I have `python3` and a `rst2html` with `#!/usr/bin/python3` shebang.
2. `geany_gtkdoc_header.m4` explicitly checks for Python 2.7 if I read it right.
3. ctags tests all the .py files use `#!/usr/bin/python` or `#!/usr/bin/env python` both of which will fail
4. as above for scripts
5. python templates use `#!/usr/bin/env python`
There may be more.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2896
This is the end of the end of the build log:
```
Command line defined: "GEANY_INSTALLER_NAME=geany-1.39_ci_20230416143039_83b8f7b_setup.exe"
Command line defined: "GEANY_RELEASE_DIR=/build/geany-release"
Command line defined: "GEANY_THEMES_DIR=/build/geany-themes"
Command line defined: "GTK_BUNDLE_DIR=/build/gtk-bundle"
Processing config: /etc/nsisconf.nsh
Processing script file: "/build/geany-build/geany.nsi" (UTF8)
File: "/build/geany-release\bin\*Geany*.dll" -> no files found.
Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] |
/oname=outfile one_file_only)
Error in script "/build/geany-build/geany.nsi" on line 144 -- aborting creation process
Error: Process completed with exit code 1.
```
It appears it started happening after https://github.com/geany/geany/pull/3432. @eht16 Any idea what could be wrong?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3461
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3461(a)github.com>
This follows filetypes: Groovy, Kotlin (except NaN?), Haxe, Java, Julia (I think), Rust. Some other filetypes use secondary keywords for other things besides types (builtin functions?).
Doesn't include `signed` and `unsigned` as they can be type modifiers too (can include if wanted).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3448
-- Commit Summary --
* [C, C++] Move built-in type keywords to secondary list
-- File Changes --
M data/filedefs/filetypes.c (6)
M data/filedefs/filetypes.cpp (6)
-- Patch Links --
https://github.com/geany/geany/pull/3448.patchhttps://github.com/geany/geany/pull/3448.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3448
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3448(a)github.com>