Looks good! Thanks.
> While "rainbow colours" sounds nice "Bracketcolors" is more descriptive, so a user looking for it is more likely to find it.
Full agree.
@asifamin13 maybe you could just mention "rainbow colors" in the README, that might already suffice that users can find it also with this name.
I did a quick code review without having a deeper look at the logic.
From a quick test, it works as advertised and I got many fancy brackets :).
A few comments @asifamin13:
- Could you add the plugin name in https://github.com/geany/geany-plugins/blob/master/build/geany-plugins.nsi#… (this is for the Windows installer, use `bracketcolors.dll`)
- As Geany itself also colorizes the brackets in an idle callback, did you check that both implementations do not interfere with each other?
- I got a few compiler warnings which might be worth looking into:
```
BracketMap.cc: In member function 'void BracketMap::Show()':
BracketMap.cc:122:21: warning: loop variable 'it' creates a copy from type 'const std::pair<const int, std::tuple<int, int> >' [-Wrange-loop-construct]
122 | for (const auto it : mBracketMap) {
| ^~
BracketMap.cc:122:21: note: use reference type to prevent copying
122 | for (const auto it : mBracketMap) {
| ^~
| &
bracketcolors.cc: In function 'gboolean utils_parse_color(const gchar*, GdkColor*)':
bracketcolors.cc:276:27: warning: 'gboolean gdk_color_parse(const gchar*, GdkColor*)' is deprecated: Use 'gdk_rgba_parse' instead [-Wdeprecated-declarations]
276 | return gdk_color_parse(spec, color);
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gdk/gdkcairo.h:26,
from /usr/include/gtk-3.0/gdk/gdk.h:33,
from /usr/include/gtk-3.0/gtk/gtk.h:30,
from /home/enrico/apps/include/geany/gtkcompat.h:30,
from /home/enrico/apps/include/geany/editor.h:27,
from /home/enrico/apps/include/geany/document.h:31,
from /home/enrico/apps/include/geany/build.h:26,
from /home/enrico/apps/include/geany/geanyplugin.h:36,
from bracketcolors.cc:40:
/usr/include/gtk-3.0/gdk/deprecated/gdkcolor.h:79:11: note: declared here
79 | gboolean gdk_color_parse (const gchar *spec,
| ^~~~~~~~~~~~~~~
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1418077202
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1418077202(a)github.com>
My [keywords] section is as follows:
`primary=Cheese Käse Сыр Сыp Cыp \u0421ыр Déjà Уже Already Bereits HНOО`
I have a UTF-8 encoded file colored like this:
**Cheese
Käse**
Сыр Сыp **Cыp**
**Déjà**
Уже
**Already
Bereits
HНOО**
Words in **bold** are treated like keywords but any word with initial Cyrillic letter is ignored.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3370
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/repo-discussions/3370(a)github.com>
just like this，this software is notepad++：
but now in geany。When searching in multiple files, the search string is not highlighted in the search results, which makes it difficult for people to quickly see the search string.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3380
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3380(a)github.com>
While "rainbow colours" sounds nice "Bracketcolors" is more descriptive, so a user looking for it is more likely to find it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1416876357
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1416876357(a)github.com>
I updated the commit message with a reference to that issue. Raindow brackets sounds cool, I wish I knew of that issue before starting this
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1416857959
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1416857959(a)github.com>
Perhaps the description and/or commit message should mention #1148?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1416838077
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1416838077(a)github.com>
Create a macro with about 100 steps (press and hold a letter key), edit the macro. The edit macro window extends beyond the screen top and bottom, no scroll bar. Escape does not close the window, cannot see the buttons at the bottom to close the window. Have to kill the Geany process.
Please size the macro edit window to fit the screen and add a scroll bar. Should escape close the macro edit window?
geany 1.38 (built on 2021-10-14 with GTK 3.24.30, GLib 2.68.4); Ubuntu 22.10, Wayland; AMD64.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1222
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/issues/1222(a)github.com>
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1223
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/issues/1223(a)github.com>
Create a macro with about 200 steps, edit the macro. The edit macro window extends beyond the screen top and bottom, no scroll bar. Escape does not close the window, cannot see the buttons at the bottom to close the window. Have to kill the Geany process.
Please size the macro edit window to fit the screen and add a scroll bar. Should escape close the macro edit window?
geany 1.38 (built on 2021-10-14 with GTK 3.24.30, GLib 2.68.4); Ubuntu 22.10, Wayland; AMD64.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3384
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3384(a)github.com>
underscores do not show in the editor, you can find them with ctrl+f (if you know they are there) but you can't see them
ii geany 1.36-1build1 amd64 fast and lightweight IDE
PRETTY_NAME="Ubuntu 20.04.5 LTS"
(xfce xubuntu)
I use a relatively stock OS install, no custom fonts in the DE etc
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3383
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3383(a)github.com>