--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3081
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3081(a)github.com>
This prevents a potential crash if `sidebar_update_tag_list()` is called with update=true and document=NULL.
Found this by accident while testing the tag tree filter PR.
Currently, this is no problem as `sidebar_update_tag_list()` is not called with update=true and document=NULL but just in case it might happen.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3080
-- Commit Summary --
* Update doc->priv->tag_tree_dirty only if doc is set
-- File Changes --
M src/sidebar.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/3080.patchhttps://github.com/geany/geany/pull/3080.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3080
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3080(a)github.com>
Maybe have a unit test for this?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/349#issuecomment-1003760117
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/349/1003760117(a)github.com>
Closed #349.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/349#event-5832799965
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issue/349/issue_event/5832799965(a)github.com>
Good, one more mysterious bug away.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/349#issuecomment-1003737635
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/349/1003737635(a)github.com>
It does!
I guess we can close this now.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/349#issuecomment-1003735268
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/349/1003735268(a)github.com>
Is it possible to implement persistent blocks in Geany? Got used to them since Turbo/Borland Pascal and Delphi. :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3079
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3079(a)github.com>
clang on Windows throws -Wdll-attribute-on-declaration. It expects
dllexport to be done on the first declaration.
Make use of G_MODULE_EXPORT instead of custom solution as GTK is a
requirement.
Signed-off-by: Rosen Penev <rosenp(a)gmail.com>
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3067
-- Commit Summary --
* fix compilation with clang on Windows
-- File Changes --
M scintilla/gtk/ScintillaGTK.cxx (7)
M scintilla/include/ScintillaWidget.h (18)
M src/build.h (5)
M src/dialogs.c (2)
M src/dialogs.h (5)
M src/document.h (26)
M src/editor.c (3)
M src/editor.h (17)
M src/encodings.h (3)
M src/filetypes.h (6)
M src/geanyobject.h (2)
M src/highlighting.h (5)
M src/keybindings.h (6)
M src/main.h (4)
M src/msgwindow.h (9)
M src/navqueue.h (1)
M src/plugindata.h (6)
M src/pluginutils.h (14)
M src/project.h (2)
M src/sciwrappers.h (52)
M src/search.h (2)
M src/spawn.h (7)
M src/stash.h (21)
M src/symbols.h (1)
M src/templates.h (1)
M src/ui_utils.h (21)
M src/utils.h (27)
-- Patch Links --
https://github.com/geany/geany/pull/3067.patchhttps://github.com/geany/geany/pull/3067.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3067
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3067(a)github.com>
I'm not sure how others but I personally just HATE the huge status bar
of GTK 3. It's such a colossal waste of precious vertical space and not
making the height adjustable is a terrible design choice IMO.
Anyway, end of ranting, the GTK status bar is just a GtkBox and a label
(plus some message stack that Geany doesn't even use) so it's no problem
to replace the statusbar with these and set the height to a sane amount
of pixels.
To me, the result is MUCH better and from the themes I tried, it looks
the same like the original status bar (apart from the height of course).
There might be a problem with plugins that try to access the status bar
directly and don't use msgwin_status_add(). The only plugin that seems
to do that (correctly) is the "web helper" plugin but from the code
it appears it falls back to creating a fake status bar if it doesn't
locate the one from Geany so it won't crash.
What do you think?
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3058
-- Commit Summary --
* Make status bar thinner by using GtkBox instead of GtkStatusBar
-- File Changes --
M data/geany.glade (18)
M src/libmain.c (2)
M src/ui_utils.c (39)
M src/ui_utils.h (3)
-- Patch Links --
https://github.com/geany/geany/pull/3058.patchhttps://github.com/geany/geany/pull/3058.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3058
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3058(a)github.com>
Geany 1.28 Release (Windows and Linux) and Geany 1.29 and I think also Geany 1.27 and before
Lines that start with ';' are syntax highlighted as comment.
Lines that start with '#' are syntax highlighted as comment.
An entry "key=value" in a line starting with ';' is shown in the symbols list.
An entry "key=value" in a line starting with '#' is not shown in the symbols list.
I attached a small test file test.ini, but I had to rename it to test.ini.txt because github refused to upload test.ini
[test.ini.txt](https://github.com/geany/geany/files/464268/test.ini.txt)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1220