Update sci_get_selected_text_length() so it returns the same value like
Scintilla 5.1.4 and earlier versions.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3099
-- Commit Summary --
* Update sci_get_selected_text_length() after change to Scintilla 5.1.5
* Fix warning
-- File Changes --
M src/sciwrappers.c (6)
M src/ui_utils.c (4)
-- Patch Links --
https://github.com/geany/geany/pull/3099.patchhttps://github.com/geany/geany/pull/3099.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3099
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3099(a)github.com>
While editing a C document in the right-side window, the cursor didn't go to the beginning or end of the line when using the home and end key.
```
00:19:59.095696: GLib-GIO DEBUG : _g_io_module_get_default: Found default implementation gvfs (GDaemonVfs) for ‘gio-vfs’
00:19:59.118762: Geany INFO : Geany 1.39 (git >= 11a1f32f), en_US.utf8
00:19:59.118773: Geany INFO : GTK 3.24.30, GLib 2.70.1
00:19:59.118796: Geany INFO : OS: Manjaro Linux
00:19:59.118811: Geany INFO : System data dir: /home/andy/.local/share/geany
00:19:59.118816: Geany INFO : User config dir: /home/andy/.config/geany
00:19:59.218196: Geany INFO : Loaded GTK+ CSS theme '/home/andy/.local/share/geany/geany.css'
00:19:59.218896: Geany INFO : Loaded GTK+ CSS theme '/home/andy/.local/share/geany/geany-3.20.css'
00:19:59.222820: Geany INFO : System plugin path: /home/andy/.local/lib/geany
00:19:59.228730: Geany INFO : Added filetype Clojure (64).
00:19:59.228737: Geany INFO : Added filetype Nim (65).
00:19:59.228741: Geany INFO : Added filetype Graphviz (66).
00:19:59.228745: Geany INFO : Added filetype Groovy (67).
00:19:59.228749: Geany INFO : Added filetype CUDA (68).
00:19:59.228752: Geany INFO : Added filetype Meson (69).
00:19:59.228756: Geany INFO : Added filetype JSON (70).
00:19:59.228760: Geany INFO : Added filetype Arduino (71).
00:19:59.228764: Geany INFO : Added filetype Kotlin (72).
00:19:59.228767: Geany INFO : Added filetype Scala (73).
00:19:59.228770: Geany INFO : Added filetype Genie (74).
00:19:59.228774: Geany INFO : Added filetype Swift (75).
00:19:59.228777: Geany INFO : Added filetype Cython (76).
00:19:59.228781: Geany INFO : Added filetype TypeScript (77).
00:19:59.241050: Geany INFO : Loaded libvte from libvte-2.91.so
00:19:59.256054: Geany INFO : Loaded: /home/andy/.local/lib/geany/debugger.so (Debugger)
00:19:59.259442: Geany INFO : Loaded: /home/andy/.local/lib/geany/filebrowser.so (File Browser)
00:19:59.260744: SpellCheck DEBUG : Initializing Enchant library version 2.3.1
00:19:59.263159: (null) WARNING : Error loading plugin: libhspell.so.0: cannot open shared object file: No such file or directory
00:19:59.263312: (null) WARNING : Error loading plugin: libnuspell.so.5: cannot open shared object file: No such file or directory
00:19:59.263494: (null) WARNING : Error loading plugin: libvoikko.so.1: cannot open shared object file: No such file or directory
00:19:59.263527: GLib DEBUG : setenv()/putenv() are not thread-safe and should not be used after threads are created
00:19:59.266247: Geany INFO : Loaded: /home/andy/.local/lib/geany/spellcheck.so (Spell Check)
00:19:59.266920: Geany INFO : Loaded: /home/andy/.local/lib/geany/splitwindow.so (Split Window)
00:19:59.271803: Geany INFO : unknown : None (UTF-8)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3047
Symbols viewer incomplete with the following Python code.
`class Foo:
Bar = 'Xyzzy'
Baz = 'Offending character >>> = <<<'
`
No symbol Baz but remove that final '=' and it appears.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2999
This is a tracking bug where we are with universal-ctags syncing regarding individual parsers. After https://github.com/geany/geany/pull/1160 gets in, the work on merging the parsers can start.
If someone wants to merge some of the parsers, it would be best to drop a line here so people don't do the same work in parallel.
Below is the state of individual parsers -> shows the general direction of from where to where the changes should be brought. <-> means changes will probably be necessary in both Geany and uctags parsers.
**basically merged**
- [ ] asm
- [ ] cobol
- [ ] css
- [ ] erlang
- [ ] json
- [ ] objc
**waiting for varType in uctags**, see https://github.com/universal-ctags/ctags/issues/862 (simple to merge)
- [ ] go (Geany->uctags)
- [ ] rust (Geany->uctags)
**normal diffs**
- [ ] basic (uctags->Geany)
- [ ] diff (uctags->Geany)
- [ ] fortran (uctags<->Geany)
- [ ] html (Geany->uctags)
- [ ] jscript (uctags<->Geany)
- [ ] lua (uctags->Geany)
- [ ] make (uctags->Geany)
- [ ] pascal (Geany->uctags)
- [ ] perl (uctags->Geany)
- [ ] php (uctags<->Geany)
- [ ] ruby (uctags->Geany)
- [ ] sql (uctags->Geany)
- [ ] tcl (Geany->uctags)
**big diffs**
- [ ] python (uctags->Geany)
- [ ] r (uctags<->Geany)
- [ ] sh (uctags->Geany)
- [ ] verilog (uctags->Geany)
**unmergable diffs**
- [ ] latex (uctags) vs tex (Geany) - different parsers - haven't checked what they do and if they should be treated as a parser of a single language or not
- [ ] matlab (we have regex-based parser, uctags has hand-written one - we should probably grab the uctags one)
- [ ] VHDL (different parsers from different people - uctags parser contains more LOCs so it's probably better :-)
- [ ] c.c (meh)
**extra parsers in Geany**
abaqus, abc, actionscript, asciidoc, conf, docbook, haskell, haxe, markdown, nsis, powershell, rest, txt2tags
**extra parsers in uctags**
ada, ant, asp, awk, beta, clojure, dbusintrospect, dosbatch, dts, eiffel, falcon, flex, glade, jprop, lisp, maven2, myrddin, ocaml, perl6, plist, protobuf, relaxng, rex, rpmspec, rst, scheme, slang, sml, svg, ttcn, vim, windres, xslt, yacc
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1162
The upstream TCL parser is split into 3 parts:
1. The parser of the TCL language: https://github.com/universal-ctags/ctags/blob/master/parsers/tcl.c
2. The parser of TCLOO (the "current" object-oriented extension): https://github.com/universal-ctags/ctags/blob/master/parsers/tcloo.c
3. The parser of ITCL ("legacy" object-oriented extension): https://github.com/universal-ctags/ctags/blob/master/parsers/itcl.c
One can use the combo of 1+2 or 1+3 but it's not possible to use 1+2+3. uctags distinguishes which parser to use based on the file extension ("tcl" vs "itcl"). Our current parser generates tags both for ITCL and TCLOO. The question now is what to do:
1. Keep our parser (it doesn't seem to be so advanced like the upstream parser which is token-based and it means maintaining it by ourselves).
2. Use one of the combos TCLOO+TCL or ITCL+TCL and sacrifice the other OO extension (not sure which one would be better to use, I'm not a TCL user).
3. Introduce a new filetype so there will be "tcl" (which would be TCLOO+TCL) and "itcl" (which would be ITCL+TCL).
To reduce the amount of code we have to maintain, I personally would prefer (2) or (3). What do you think?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3103
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3103(a)github.com>
Unfortunately Gtk3 dropped the support for flipping through notebook pages for 'usability reasons' without making it available again with some kind of options. So applications like gnome-terminal started to re-implement this feature.
For maintaining feature parity with the Gtk2 backend, geany should re-implement scrolling through notebook pages as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/872
Hello, I am using Geany 1.37.1 (also tested latest git commit) on Manjaro Linux.
When I press "Ctrl + Shift + V" without switching to terminal tab in the Message Window, Geany crashes with error message:
```
/usr/include/c++/11.1.0/bits/shared_ptr_base.h:976: std::__shared_ptr_access<_Tp, _Lp, <anonymous>, <anonymous> >::element_type& std::__shared_ptr_access<_Tp, _Lp, <anonymous>, <anonymous> >::operator*() const [with _Tp = vte::platform::Clipboard; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic; bool <anonymous> = false; bool <anonymous> = false; std::__shared_ptr_access<_Tp, _Lp, <anonymous>, <anonymous> >::element_type = vte::platform::Clipboard]: Assertion '_M_get() != nullptr' failed.
中止 (核心已傾印)
```
Crash does not happen if virtual terminal is disabled in the settings or switching to terminal tab first. Pressing "Ctrl + Shift + V" also does not crash after switching to terminal tab and then switching to another tab.
Here is backtrace:
```
Thread 7 (Thread 0x7ffff18a0640 (LWP 49412) "pool-geany"):
#0 0x00007ffff7b8118d in syscall () at /usr/lib/libc.so.6
#1 0x00007ffff6d3b06b in g_cond_wait_until () at /usr/lib/libglib-2.0.so.0
#2 0x00007ffff6cbc8b3 in () at /usr/lib/libglib-2.0.so.0
#3 0x00007ffff6cbca44 in g_async_queue_timeout_pop () at /usr/lib/libglib-2.0.so.0
#4 0x00007ffff6d1dd2a in () at /usr/lib/libglib-2.0.so.0
#5 0x00007ffff6d1b0c1 in () at /usr/lib/libglib-2.0.so.0
#6 0x00007ffff63eb259 in start_thread () at /usr/lib/libpthread.so.0
#7 0x00007ffff7b865e3 in clone () at /usr/lib/libc.so.6
Thread 3 (Thread 0x7ffff2abe640 (LWP 49408) "gdbus"):
#0 0x00007ffff7b7bb2f in poll () at /usr/lib/libc.so.6
#1 0x00007ffff6d40ae8 in () at /usr/lib/libglib-2.0.so.0
#2 0x00007ffff6cec593 in g_main_loop_run () at /usr/lib/libglib-2.0.so.0
#3 0x00007ffff6f315b8 in () at /usr/lib/libgio-2.0.so.0
#4 0x00007ffff6d1b0c1 in () at /usr/lib/libglib-2.0.so.0
#5 0x00007ffff63eb259 in start_thread () at /usr/lib/libpthread.so.0
#6 0x00007ffff7b865e3 in clone () at /usr/lib/libc.so.6
Thread 2 (Thread 0x7ffff32bf640 (LWP 49407) "gmain"):
#0 0x00007ffff7b7bb2f in poll () at /usr/lib/libc.so.6
#1 0x00007ffff6d40ae8 in () at /usr/lib/libglib-2.0.so.0
#2 0x00007ffff6cea781 in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0
#3 0x00007ffff6cea7d2 in () at /usr/lib/libglib-2.0.so.0
#4 0x00007ffff6d1b0c1 in () at /usr/lib/libglib-2.0.so.0
#5 0x00007ffff63eb259 in start_thread () at /usr/lib/libpthread.so.0
#6 0x00007ffff7b865e3 in clone () at /usr/lib/libc.so.6
Thread 1 (Thread 0x7ffff5ad8940 (LWP 49403) "geany"):
#0 0x00007ffff7ac4d22 in raise () at /usr/lib/libc.so.6
#1 0x00007ffff7aae862 in abort () at /usr/lib/libc.so.6
#2 0x00007fffe0962f2a in std::__replacement_assert(char const*, int, char const*, char const*) (__file=__file@entry=0x7fffe09aea80 "/usr/include/c++/11.1.0/bits/shared_ptr_base.h", __line=__line@entry=976, __function=__function@entry=0x7fffe09ae8e8 "std::__shared_ptr_access<_Tp, _Lp, <anonymous>, <anonymous> >::element_type& std::__shared_ptr_access<_Tp, _Lp, <anonymous>, <anonymous> >::operator*() const [with _Tp = vte::platform::Clipboard; __gn"..., __condition=__condition@entry=0x7fffe09ae8b4 "_M_get() != nullptr") at /usr/include/c++/11.1.0/x86_64-pc-linux-gnu/bits/c++config.h:504
#3 0x00007fffe09a2d60 in std::__shared_ptr_access<vte::platform::Clipboard, (__gnu_cxx::_Lock_policy)2, false, false>::operator*() const (this=0x555556013798) at /usr/include/c++/11.1.0/bits/shared_ptr_base.h:976
#4 std::__shared_ptr_access<vte::platform::Clipboard, (__gnu_cxx::_Lock_policy)2, false, false>::operator*() const (this=0x555556013798) at /usr/include/c++/11.1.0/bits/shared_ptr_base.h:974
#5 vte::platform::Widget::clipboard_get(vte::platform::ClipboardType) const (type=vte::platform::ClipboardType::CLIPBOARD, this=0x555556013740) at ../vte/src/widget.cc:228
#6 vte::platform::Widget::clipboard_request_text(vte::platform::ClipboardType) (this=0x555556013740, type=vte::platform::ClipboardType::CLIPBOARD) at ../vte/src/widget.cc:278
#7 0x00007ffff6e05096 in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#8 0x00007ffff6e05210 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#9 0x00007fffe098ccbe in vte_terminal_paste_clipboard(VteTerminal*) (terminal=0x555555bb5a90) at ../vte/src/widget.hh:252
__PRETTY_FUNCTION__ = "void vte_terminal_paste_clipboard(VteTerminal*)"
#10 0x00007ffff6de7ddf in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#11 0x00007ffff6e10fbd in () at /usr/lib/libgobject-2.0.so.0
#12 0x00007ffff6e04cad in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#13 0x00007ffff6e05210 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#14 0x00007ffff760c341 in () at /usr/lib/libgtk-3.so.0
#15 0x00007ffff6de7ddf in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#16 0x00007ffff6e10fbd in () at /usr/lib/libgobject-2.0.so.0
#17 0x00007ffff6e042db in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#18 0x00007ffff6e05210 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#19 0x00007ffff73738fc in gtk_accel_group_activate () at /usr/lib/libgtk-3.so.0
#20 0x00007ffff7374cfe in gtk_accel_groups_activate () at /usr/lib/libgtk-3.so.0
#21 0x00007ffff76363af in gtk_window_activate_key () at /usr/lib/libgtk-3.so.0
#22 0x00007ffff7630643 in () at /usr/lib/libgtk-3.so.0
#23 0x00007ffff7362f5b in () at /usr/lib/libgtk-3.so.0
#24 0x00007ffff6de7ddf in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#25 0x00007ffff6e109cb in () at /usr/lib/libgobject-2.0.so.0
#26 0x00007ffff6e042db in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#27 0x00007ffff6e05210 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#28 0x00007ffff7622a35 in () at /usr/lib/libgtk-3.so.0
#29 0x00007ffff74be862 in () at /usr/lib/libgtk-3.so.0
#30 0x00007ffff74bfaed in gtk_main_do_event () at /usr/lib/libgtk-3.so.0
#31 0x00007ffff721ca03 in () at /usr/lib/libgdk-3.so.0
#32 0x00007ffff726ca04 in () at /usr/lib/libgdk-3.so.0
#33 0x00007ffff6ced02c in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0
#34 0x00007ffff6d40b59 in () at /usr/lib/libglib-2.0.so.0
#35 0x00007ffff6cec593 in g_main_loop_run () at /usr/lib/libglib-2.0.so.0
#36 0x00007ffff74b561f in gtk_main () at /usr/lib/libgtk-3.so.0
#37 0x00007ffff7cd8a18 in main_lib (argc=<optimized out>, argv=<optimized out>) at libmain.c:1294
doc = 0x55555623ce40
config_dir_result = <optimized out>
locale = <optimized out>
utf8_configdir = <optimized out>
os_info = <optimized out>
#38 0x00007ffff7aafb25 in __libc_start_main () at /usr/lib/libc.so.6
#39 0x000055555555505e in _start ()
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2813
For some filetypes (more specifically some Scintilla lexers) it might
happen that an event with modificationType SC_MOD_CHANGEMARKER is
sent and so the current line is added as bookmark again.
To avoid this, check if the current line has already a bookmark and
update it in this case.
Might be related to #964.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1040
-- Commit Summary --
* Addons: Bookmarks: Prevent duplicating bookmarks when editing line
-- File Changes --
M addons/src/ao_bookmarklist.c (26)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1040.patchhttps://github.com/geany/geany-plugins/pull/1040.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1040
This is running under Sway, testing with Wayland native apps only (no xwayland).
When I first open a file in Geany, I can copy out of Geany and paste into another program by selecting and then middle clicking in the usual way. I can do that multiple times with different selections. If I then select something ("foo" for example) in the other program, I can middle click paste it into Geany. I can do this with multiple selections as well. All OK so far.
At this point if I select something in Geany ("bar" for example), I can no longer middle click paste it outside of Geany. I just get "foo" instead, even if I make sure to unselect "foo" in the other app before selecting "bar" in Geany. Middle click copy/paste within Geany works fine still. It also works fine within and between non-Geany applications. It is as if Geany is now using a different primary buffer than everything else.
Opening a new file in Geany (or closing and reopening an existing one) gets things working again temporarily.
I've tested this with Geany 1.36 and also the latest Master branch. I also tried applying the patch from here, but saw no difference: https://sourceforge.net/p/scintilla/bugs/2127/
I have mainly been using kitty (0.18.3) and firefox (78.3.0 esr) as the other applications. Sway is version 1.5-3. This is on Debian Bullseye. I also briefly tried to check if SciTe exhibits the same behavior, but middle click copy paste did not work at all there (at least to other programs, not sure if it worked within SciTe).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2629