Newer versions of libxml2 (used by lxml) crash in tostring() when no encoding argument is present. Passing "unicode" as encoding makes tostring() returning already a Python unicode string, so we don't need to decode it anymore.
On Debian Sid where libxml2 2.9.12 is included, the following error occurs without the change:
```
/usr/bin/python3 ../scripts/gen-api-gtkdoc.py xml -d . -o geany-gtkdoc.h \
--sci-output geany-sciwrappers-gtkdoc.h
Traceback (most recent call last):
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 460, in <module>
sys.exit(main(sys.argv))
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 389, in main
e = DoxyStruct.from_compounddef(n0)
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 321, in from_compounddef
e.add_member(p)
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 233, in add_member
proc.process_element(xml.find("detaileddescription"))
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 136, in process_element
s = self.__process_element(xml)
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 163, in __process_element
s += self.__process_element(n) + "\n"
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 167, in __process_element
ss = self.at.cb(n.get("kind"), self.__process_element(n))
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 163, in __process_element
s += self.__process_element(n) + "\n"
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 170, in __process_element
s += self.get_program_listing(n)
File "/build/geany-1.37.1-1+20210903gitb7bd5fa/doc/../scripts/gen-api-gtkdoc.py", line 126, in get_program_listing
arr.append(" " + tostring(etree.HTML(html), method="text").decode("utf-8"))
File "src/lxml/etree.pyx", line 3437, in lxml.etree.tostring
File "src/lxml/serializer.pxi", line 103, in lxml.etree._tostring
File "src/lxml/serializer.pxi", line 75, in lxml.etree._textToString
UnicodeEncodeError: 'ascii' codec can't encode character '\xe1' in position 130970: ordinal not in range(128)
```
I'm not completely sure why this happens with libxml 2.9.12 (2.9.10 works fine), the XML contents which are processed here should be plain ASCII. Anyway, it might not be bad to set the encoding anyways.
To reproduce, start a Docker container with a Debian Sid image, like: `docker run --rm -it debian:sid` and within the container execute:
```bash
apt-get update && apt-get install --no-install-recommends -y git intltool libtool build-essential libgtk-3-dev python3-docutils rst2pdf doxygen python3-lxml nano
git clone https://github.com/geany/geany
cd geany
./autogen.sh
make -C doc
```
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2885
-- Commit Summary --
* Use "encoding" keyword argument for lxml's tostring()
-- File Changes --
M scripts/gen-api-gtkdoc.py (6)
-- Patch Links --
https://github.com/geany/geany/pull/2885.patchhttps://github.com/geany/geany/pull/2885.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2885
When I go to create a project after I select the desired directory and give it a project name, is says it cannot find the file or the directory name.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2895
Sometimes I deal with wrongly-formatted code files, which contain empty spaces at the row end, like in the following;
```
text here; <- (lots of empty spaces here)
```
however, when I press CTRL + DEL starting from the end of the line, the whole last word is deleted together with the empty spaces.
While this clearly makes sense when there's only one space (e.g. I'm deleting word after word in a natural language text), in my scenario it's uncomfortable, I think some additional key combination would be useful in order to delete separately groups of spaces (and groups of tabs maybe), and groups of non-empty characters.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2893
Hello!
On latest master `clang` throws these warnings:
```
In file included from src/ViewStyle.cxx:26:
./src/Style.h:76:2: warning: explicitly defaulted move constructor is implicitly deleted [-Wdefaulted-function-deleted]
Style(Style &&) = default;
^
./src/Style.h:71:12: note: move constructor of 'Style' is implicitly deleted because field 'font' has a deleted move constructor
FontAlias font;
^
./src/Style.h:38:2: note: 'FontAlias' has been explicitly marked deleted here
FontAlias(FontAlias &&) = delete;
^
```
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2891
Hello!
While chasing down these `clang` warnings I found that some code is redundant and can be safely removed:
```
main/parse.c:5007:26: warning: unused function 'FallbackParser' [-Wunused-function]
static parserDefinition *FallbackParser (void)
^
main/parse.c:5040:26: warning: unused function 'CTagsParser' [-Wunused-function]
static parserDefinition *CTagsParser (void)
^
main/parse.c:5355:26: warning: unused function 'CTagsSelfTestParser' [-Wunused-function]
static parserDefinition *CTagsSelfTestParser (void)
^
```
This is because we explicitly define `EXTERNAL_PARSER_LIST ` in tm_parsers.h at https://github.com/geany/geany/blob/master/src/tagmanager/tm_parsers.h#L16 so guess no need to check for not defined case?
Thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2890
-- Commit Summary --
* Remove redundant code
-- File Changes --
M ctags/main/parse.c (338)
M ctags/main/parse_p.h (13)
-- Patch Links --
https://github.com/geany/geany/pull/2890.patchhttps://github.com/geany/geany/pull/2890.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2890
The ide info window has a translation mismatch.
Where is it:
"Uma IDE rápido e leve"
Right:
"Uma IDE rápida e leve" or
"Um editor rápido e leve".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2871
It would be better to add to the search and replace dialog an option whether to wrap around the document (continue from the beginning when the end is reached and vice versa). Asking it each time is inconvenient and makes Geany unusable.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2887