As discussed in https://github.com/geany/geany/pull/1180.
This change adds two new functions: `document_rename_file_and_save()`, and `document_rename_and_save()`. `document_rename_file_and_save()` is kind of like the combination of `document_rename_file()` and `document_save_file_as()`, and is strictly about renaming the associated file, and doing the stuff necessary before and after the file has been renamed, like disabling file monitoring, and putting it back if a rename fails, saving/restoring file disk status, etc.
`document_rename_and_save()` OTOH is more of a wrapper, and is about renaming the document itself. It doesn't require the document to have an associated file to it (i.e. `doc->real_path != NULL`). But if there is an associated file, the file is also renamed, i.e., `document_rename_file_and_save()` is called. The algorithm to check if the file has to be overwritten is also contained in it. This function should be adaptable to other implementations like [in-place renaming](https://github.com/konsolebox/geany/tree/docs_rename).
In `dialogs.c`, stuff about resetting `doc->tm_file` and calling `build_menu_update()` has been moved to `document_save_file_as()`, since both are essentially needed to be done by anyone that calls the function. It helps significantly simplify the two new functions and the functions in `dialogs.c`.
The function `save_as_dialog_handle_response()` has been refactored, and is now simpler since the "overwrite file?" prompt has been moved to `document_rename_and_save()`, and since it can now directly call `document_rename_and_save()` and `document_save_file_as()`. `dialogs_show_save_as()` now also directly calls `document_save_file_as()` if `interface_prefs.use_native_windows_dialogs == TRUE`. `handle_save_as()` is no longer needed, so it's been removed.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1194
-- Commit Summary --
* Add document_rename_file_and_save()
* Do not make document_rename_file_and_save() an API function for now
* Add document_rename_and_save()
* Move resetting GeanyDocument::tm_file, and calling build_menu_update() to document_save_file_as()
* Rework Save-As functions in dialogs.c
* dialogs_show_save_as: g_free(utf8_name);
-- File Changes --
M src/dialogs.c (78)
M src/document.c (81)
M src/document.h (4)
-- Patch Links --
https://github.com/geany/geany/pull/1194.patchhttps://github.com/geany/geany/pull/1194.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1194
Zooming itself is fine, it works if "zoom in(out)" menu items are clicked. Default zooming hotkeys (which are written on these menu items) do not have any effect.
Geany 1.32, macOS 10.12.6
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1712
Hi,
i switched completely to geany on all my platforms because geany is available for windows, Linux Mint and Raspberry OS and is active in development. On Windows i used pspad and there was a feature which could compare two files and show the differences, i did not found anything like that for geany. Is there such a feature ?
Thank you
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1009
Currently Geany already provides one long line marker, which I find extremely helpful.
I find it so useful, in fact, I can think of a few situations where I could use an extra one.
Primarily -- Python's PEP 8 recommends 72 characters for docstrings, though the real code's line limit is longer.
Additionally -- Others may be working in heavily indented code and could use a vertical indicator for some specific nesting level, to help keep their place.
So if possible, I'd love the ability to set two separate long line markers of different colors in settings. (The second one would be turned off by default of course), just so I can watch one column for comments and the other for code.
Thanks for the project, it's been a huge help!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2598
It would be useful if Geany supported build profiles (sets of build commands) and let you assign a different build profile to each geany tab. The user should be able to pick a default build profile that new tabs / files will use by default and geany should remember which build profiles were assigned to specific files.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2607
There are times I like auto-scroll and times I don't like it, when I'm looking at errors/warnings during an ongoing compile I don't like it, I would appreciate the auto-scroll disabling when I move it away from the bottom, only re-enabling when it is put back, this can easily be detected by simply grabbing both value prior to adding in a line, adding the line then checking the values are the same, if auto-scroll is handled by a different thread then it just needs to check the distance is within 1 line as it is very unlikely the thread would be further behind than one waiting for input from another process
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2772
For a fluent coding I love to not change my hand position to use the
arrow keys!
I realy like auto-closing.
If I activate the auto closing brackets, braces, parenthesis and
quotes feature, the closing characters are inserted, but to continue after
these, the arrow keys are necessary.
The modification I made: if autoclosing AND consuming is activated in
options, if a closing character is typed and the following character
matches this, not both characters stay - one deleted - curr pos
afterwards.
Example: the | marks the curr position:
"|"
"hallo|"
[Then the " is hit]
"hallo"|
The " is reachable without changing hand pos. Same for the other
"autoclosers".
I saw this in other IDEs and I want it in my Geany.
I don't know about internationatlization, so this is an incomplete
feature.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2122
-- Commit Summary --
* Consume closing brackets, braces, parenthesis, single and double quotes
-- File Changes --
M data/geany.glade (239)
M scintilla/include/Scintilla.h (1)
M scintilla/src/Editor.cxx (5)
M src/editor.c (67)
M src/editor.h (1)
M src/keyfile.c (2)
M src/prefs.c (43)
M src/sciwrappers.c (9)
M src/sciwrappers.h (3)
-- Patch Links --
https://github.com/geany/geany/pull/2122.patchhttps://github.com/geany/geany/pull/2122.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2122
PHP 7.3 has changed the Heredoc/Nowdoc syntax, so that the ending delimiter doesn't need to be at the beginning of a line, and can be followed by other expressions. the following examples are valid php code now:
```
<?php
$var = <<<EOL
this is a test
EOL;
```
```
<?php
$vector = [<<<EOL
this
is
a
test
EOL, 'other value' ];
```
But both syntax examples are not properly parsed/highlighted on Geany.
I'm not sure if this is a Scintilla bug or a Geany bug - I can see Geany has a php parser, which today is unable to parse the new syntax (code is [here](https://github.com/geany/geany/blob/master/ctags/parsers/php.c)). I tried to open a ticket on Scintilla about this, but I am not allowed to do so (looks like you need approval from the project owners to open a ticked there).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2414
Xubuntu 20.04
Geany 1.37.1, GTK 3.24.20, GLib 2.64.3
```
(gdb) run
Starting program: /usr/local/bin/geany
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff548c700 (LWP 80774)]
[New Thread 0x7ffff4be7700 (LWP 80775)]
[New Thread 0x7fffecc9e700 (LWP 80776)]
[New Thread 0x7fffe7fff700 (LWP 80777)]
[Detaching after fork from child process 80778]
[Thread 0x7fffe7fff700 (LWP 80777) exited]
(geany:80770): GLib-GObject-CRITICAL **: 08:43:38.441: g_object_get_data: assertion 'G_IS_OBJECT (object)' failed
Thread 1 "geany" received signal SIGSEGV, Segmentation fault.
0x00007fffedc844e5 in gsdlg_option (label=0x555556413338 "DICT", value=0x555556413308 "dict",
key=0x555556412e18 "proto", dlg=0x555556403ed0) at gsdlg.c:479
479 cw=g_object_get_data(G_OBJECT(hbox), DataKey);
```
For test use [complex-dialog.lua](https://github.com/geany/geany-plugins/blob/master/gean…
Also I tried GTK2-version (Geany 1.36, GTK 2.24.32 and GLib 2.64.3): works fine.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1027
Hello everyone,
Since the migration to Ubuntu 20.04, Geany no longer displays underscores.
I have to zoom in considerably to see them.
Any ideas on how to solve this annoying problem? Thanks for this fabulous software !
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502