I took the symbol tree filtering implementation from #2657 and applied some of the suggested changes on top of it:
- made the filter entry per-document
- made filtering case-insensitive
- cleared the symbol tree completely when filtering to ensure it's fully re-created
- filtering using full tag name including scope
- focusing the symbol tree after pressing enter in the search entry
What do you think?
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3055
-- Commit Summary --
* Filter symbols in the Symbol List (new feature)
* Merge branch 'tagfilter' of https://github.com/dmitryunruh/geany into dmitryunruh-tagfilter
* Simplify the filtering code a bit and follow Geany style
* Make tag filtering case-insensitive
* Add search icon to the entry
* Perform filtering in full name with scope
* Clear symbol tree before filtering to ensure it's fully re-created
* Focus the tree when pressing enter in the search entry
* Use per-document filter for symbol tree
-- File Changes --
M data/geany.glade (45)
M src/callbacks.c (44)
M src/callbacks.h (6)
M src/document.c (2)
M src/documentprivate.h (2)
M src/symbols.c (42)
-- Patch Links --
https://github.com/geany/geany/pull/3055.patchhttps://github.com/geany/geany/pull/3055.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3055
Currently
```
!commit abcd123
```
generates a URL for that commit.
It would be good if say
```
!issue 1234
```
would link to the issue/pr 1234.
Although pull requests show a URL like `geany/geany/pull/1234` it seems they will also be found with `geany/geany/issues/1234` the same as other issues, so the code just needs to be the same as `!commit` code but with URL base `https://github.com/geany/geany/issues` and limiting the argument to decimal numbers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/infrastructure/issues/3
Trying to set up Geany on my home computer and the Spellcheck plugin is refusing to work.
It comes up with "The Enchant library couldn't be initialized (unknown error(maybe the chosen language is not available))."
When I go into the plugin's preferences the "Language to us" field is empty and I can't change it.
I have tried setting the "Directory to look for" path to blank, C:\dictionaries\hunspell, C:\Program Files\LibreOffice\share\extensions\dict-en, C:\Program Files (x86)\Geany\hunspell and C:\Program Files (x86)\Geany\hunspell\dict-en and nothing works.
The Spellcheck menu option remains greyed out and the Enchant library error appears when toggling the plugin or applying the settings.
I have installed enchant_1.5.0-2_win32.zip over the Geany package as suggested on the portable version's site and the only change is that the menu entry is no longer greyed out and there is a "Default (en)" option listed there.
The plugin still doesn't work and interacting with the plugin via the Plugin Manager or plugin Preferences brings up the same error.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/939
`geany 1.37 (git >= ea649d80) (built on 2020-05-21 with GTK 3.22.30, GLib 2.56.4)`
On exit from Geany, the document list component of the addons plugin causes an error message:
`Gtk-CRITICAL gtk_widget_destroy: assertion 'GTK_IS_WIDGET (widget)' failed`
I have narrowed it down to the `ao_doc_list_finalize` function, and found that the `priv->overflow_menu_item`, though non-null, is invalid, i.e. `GTK_IS_WIDGET` returns false, exactly as the error message claims.
Not sufficiently familiar with the code to guess where the corruption is occurring, and hoping the maintainer may be able to shed some light.
Not a major problem, as the app is exiting anyway, just annoying.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/983
In the Keybindings section of [geany.txt], there are multiple instances where "Goto" is shown, but "Go to" would be correct.
For example,
_Goto matching brace_
However, in the Help -> Keyboard Shortcuts, the text reads:
_Go to matching brace_
So I am suggesting these instances are edited to use "Go to" where appropriate.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2995
Godot has been doing a tour de force lately as an open source alternative to Unity. Add support for the growing [Godot](https://github.com/godotengine/godot) engine's GDScript.
Heavily borrowed from python due to GDScript's syntax being heavily borrowed from python. To note, the language is undergoing some breaking changes that will take effect when godot 4 releases, this already should account for syntactical changes and I've already classified some number of currently-keywords as builtins even though godot 4 isn't released yet.
A little test file that I used to make sure I didn't completely break it while making the changes for the things that are different between python and gdscript:
And the prerequisite upstream pull requests:
https://github.com/ScintillaOrg/lexilla/pull/41https://github.com/universal-ctags/ctags/pull/3194
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3012
-- Commit Summary --
* Add GDScript file type
-- File Changes --
M ctags/Makefile.am (1)
A ctags/parsers/geany_gdscript.c (784)
M data/Makefile.am (1)
A data/filedefs/filetypes.gdscript (73)
M data/filetype_extensions.conf (1)
M scintilla/Makefile.am (1)
M scintilla/lexilla/include/LexicalStyles.iface (2)
M scintilla/lexilla/include/SciLexer.h (1)
A scintilla/lexilla/lexers/LexGDScript.cxx (699)
M scintilla/lexilla/src/Lexilla.cxx (3)
M scintilla/scintilla_changes.patch (1)
M src/filetypes.c (1)
M src/filetypes.h (1)
M src/highlighting.c (10)
M src/highlightingmappings.h (29)
M src/symbols.c (1)
M src/tagmanager/tm_parser.c (11)
M src/tagmanager/tm_parser.h (1)
M src/tagmanager/tm_parsers.h (3)
-- Patch Links --
https://github.com/geany/geany/pull/3012.patchhttps://github.com/geany/geany/pull/3012.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3012
In Geany the name `instance` is highlighted as a type
```C++
class c {
int i;
public:
c( int j ):i(j){}
int f(){ return i; }
} instance{1};
c another{1};
```
Note github has it correct.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/892
Using sway from latest master as windows manager,
geany 1.34.1
archlinux
If I try to paste text in geany from an xwayland app (firefox, calibre), it doesn't work. It seems to work fine when pasting from a wayland app (gnome-terminal, zathura).
I think it's a bug in geany, because pasting works fine in gedit, for example.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2079
1
problem:
after a restart of Geany one need always to click 2x the spellcheck-symbol FOR EACH document that appears automatically with a restart of Geany to see the errors although the spellcheck-symbol is activated in the symbol-bar
possible solution: check session files on startup, when "spellcheck on/off"-symbol is activated
2
instead of a "spellcheck while typing"-symbol in the tool-bar:
"spellcheck on/off"-symbol in the tool-bar (that should work exactly like "Automatic Spell Checking" in LibreOffice 7.1.3.2, what works in LibreOffice with the shortcut shift+F7)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1090