This PR is in response to #819.
Changes:
- add preferences option: 'Use collation based string compare'
- `getcmpfns()` returns either `g_utf8_collate` or `strcmp` function pointer to line operations function based on user preference
Minor:
- add help function to redirect to online documentation
- split files into `lo_prefs` and `lo_fns`
- sorry about all the annoying indentation / spacing changes / file renaming.
I'm open to hear any suggestions/improvements.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/897
-- Commit Summary --
* lineoperations: minor formatting changes
* lineoperations: add preferences
* lineoperations: split files into fns and prefs
* lineoperations: abstract string compare fns
* lineoperations: add documentation for prefs
* lineoperations: match indentation
-- File Changes --
M lineoperations/ChangeLog (9)
M lineoperations/README (102)
M lineoperations/src/Makefile.am (6)
M lineoperations/src/lineoperations.c (82)
R lineoperations/src/lo_fns.c (137)
R lineoperations/src/lo_fns.h (15)
A lineoperations/src/lo_prefs.c (127)
A lineoperations/src/lo_prefs.h (59)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/897.patchhttps://github.com/geany/geany-plugins/pull/897.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/897
on ubuntu 18.04 after added : sudo add-apt-repository ppa:geany-dev/ppa
an apt update will install 1.33 geany-plugins except for git-changebar that is broken:
```
The following packages have unmet dependencies:
geany-plugin-git-changebar : Depends: libgit2-24 (>= 0.24.0) but it is not installable
E: Unable to correct problems, you have held broken packages.
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/805
Hello,
This is the pull request for the Gibiane language support in Geany.
Sincerely,
Thibault LINDECKER,
The Cast3M support.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2246
-- Commit Summary --
* Adding native support for the Gibiane language (http://www-cast3m.cea.fr)
-- File Changes --
M ctags/Makefile.am (3)
M ctags/main/parsers.h (3)
A ctags/parsers/GIBIANE.c (352)
M data/Makefile.am (6)
A data/filedefs/filetypes.gibiane (65)
M data/filetype_extensions.conf (1)
A data/tags/std.dgibi.tags (312)
M scintilla/Makefile.am (3)
M scintilla/include/SciLexer.h (14)
M scintilla/include/Scintilla.iface (18)
A scintilla/lexers/LexGIBIANE.cxx (377)
M scintilla/src/Catalogue.cxx (1)
A scripts/create_dgibi_tags.sh (32)
M src/editor.c (24)
M src/filetypes.c (1)
M src/filetypes.h (1)
M src/highlighting.c (6)
M src/highlightingmappings.h (32)
M src/symbols.c (2)
M src/tagmanager/tm_parser.c (5)
M src/tagmanager/tm_parser.h (1)
M src/tagmanager/tm_workspace.c (7)
M src/tagmanager/tm_workspace.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/2246.patchhttps://github.com/geany/geany/pull/2246.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2246
Please see commits for details, each commit is unrelated but I thought it best to group these small changes together to save having 3 PRs with only simple changes in.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2271
-- Commit Summary --
* build.c: Fix memory leak in prepare_run_cmd()
* build.c: Refactor set_stop_button() and remove 2 unnecessary casts
* build.c: Inline add_menu_accel()
-- File Changes --
M src/build.c (51)
-- Patch Links --
https://github.com/geany/geany/pull/2271.patchhttps://github.com/geany/geany/pull/2271.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2271
In split window "End" and "Home" buttons does not work.
Also some shortcuts, like "Ctrl-S". Please check if there are
other keys and combinations which does not work properly.
This is present in Geany from at very least 1.27.
Linux Mint 18.0 with latest patches, Geany 1.30.1 built from source.
$ ./geany -V
geany 1.30.1 (built on 2017-06-03 with GTK 2.24.30, GLib 2.48.2)
$ ./geany -v &
$ Geany-INFO: Geany 1.30.1, en_US.UTF-8
Geany-INFO: GTK 2.24.30, GLib 2.48.2
Geany-INFO: System data dir: /usr/local/share/geany
Geany-INFO: User config dir: /home/pero/.config/geany
Geany-INFO: System plugin path: /usr/local/lib/geany
Geany-INFO: Added filetype Scala (61).
Geany-INFO: Added filetype Genie (62).
Geany-INFO: Added filetype CUDA (63).
Geany-INFO: Added filetype Clojure (64).
Geany-INFO: Added filetype Graphviz (65).
Geany-INFO: Added filetype Cython (66).
Geany-INFO: Added filetype JSON (67).
Geany-INFO: Added filetype Arduino (68).
Geany-INFO: Loaded libvte from libvte.so.9
Geany-INFO: Loaded: /usr/local/lib/geany/splitwindow.so (Split Window)
Geany-INFO: Loaded: /usr/local/lib/geany/filebrowser.so (File Browser)
Geany-INFO: unknown : None (UTF-8)
Geany-INFO: Loaded /usr/local/share/geany/tags/std.py.tags (Python), 5964 symbol(s).
Geany-INFO: Plugin "/usr/local/lib/geany/filebrowser.so" already loaded.
Geany-INFO: Plugin "/usr/local/lib/geany/splitwindow.so" already loaded.
Geany-INFO: Added 6 plugin(s) in '/usr/local/lib/geany'.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/577
In Geany 1.30 selecting a text with `shift`+`arrow` or `shift`+`home`/`end` leaves the last symbol under the cursor selected. For me this behavior is not apparent.
For example, pressing `shift`+`right arrow` leaves the cursor at the same position, while the symbol under the cursor gets selected. In the earlier versions (perhaps, 1.29) the same key combo selected the current symbol and moved the cursor to the next symbol.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1442
It would be awesome to have a plugin similar to XML Pretty printer to format JSON nicely
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/891
This issue is to continue discussion in the comments of #2178 and #2270 regarding the conventions/etiquette of merging a PR, especially one's own.
I suggest we categorize PRs (either using Github labels or own judgment) into the following types which probably will have different "rules" for merging:
- Obvious bug fix in the code or docs.
- Code refactoring/cleanup or larger restructuring/rewording the docs.
- Changes to the public plugin API
- Small UI change or changing default/original behaviour of something
- Large UI change
- Larger more structural changes to the code
Feel free to edit the description and re-word those or add others which are surely missing.
The criteria for a PR being mergeable might include such this as:
- None
- Waiting at least N days to see if anyone cares/objects.
- At least N people must approve the PR explicitly using Github "review" stuff.
- At least N people must have done a proper code review.
- At least N people must have actually tested it.
- It must be tested on X platforms.
Again, feel free to edit/add to this list.
I guess with the above lists, it's just a matter of attaching the criteria to each type of PR, and then codifying that somewhere like HACKING, the wiki, a new CONTRIBUTING file, or wherever. One way to do this association might be to do some simple polls of the contributors.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2283