In trying to give named parameters to mixins, I noticed you can get away doing this:
```pug
mixin simpleField({label, name, isRequired, leftIconClass})
.field
label.label(for=`txt-${name}`)= label
div(class=`control ${leftIconClass ? "has-icons-left" : ""}`)
input.input(
id=`txt-${name}`,
name= name,
type='text',
required= isRequired)
if leftIconClass
span.icon.is-small.is-left
i.fas(class= leftIconClass)
+simpleField({ label: "Full Name", name: "host-full-name", isRequired: true, leftIconClass: "fa-user" })
```
Is there a good chance this is going to break in the future?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2083
>From my early tests it works fine loading and saving embedded NUL bytes, but I expect many features not to work properly (although e.g. regex search seems happy, yet displaying results not so much). It however should help getting to a point where these could be handled properly, and is handy also for slightly broken files and alike.
Anyway for now such files are loaded read-only and display a warning to the user to avoid most problems.
Related to (and should fix for the most part) #618 and #1708 (and possibly others).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1709
-- Commit Summary --
* Avoid weird length value
* Add sci_set_text_with_length()
* Don't cut the loaded data at the first NUL when passing it to Scintilla
* Don't cut UTF-8 documents at the first NUL byte when saving them
* encodings: Accept NULs when validating UTF-8
* Properly load files with embedded NULs
* Show an infobar for files with embedded NULs
-- File Changes --
M src/document.c (58)
M src/documentprivate.h (1)
M src/encodings.c (118)
M src/encodingsprivate.h (2)
M src/sciwrappers.c (10)
M src/sciwrappers.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/1709.patchhttps://github.com/geany/geany/pull/1709.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1709
When I open a file whose character encoding can't be determined, maybe it can be assumed to be UTF-8 and display whatever can be. I have tried to open some self-extracting installer shell-scripts to alter them a bit to my needs and Geany doesn't open them saying the character encoding can't be determined.
Notepad++, for example, opens such files assuming UTF-8 encoding and displays unknown characters as "NUL". I find this feature very useful.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2081
The auto-indent doesn't work within C-style multi-line comments: it ignores the indentation of the previous line. For example (`|` is caret):
```
/**
* Multi line comment.
* Indented line|
*/
```
The current indentation after pressing Enter:
```
/**
* Multi line comment.
* Indented line
* |
*/
```
The expected indentation:
```
/**
* Multi line comment.
* Indented line
* |
*/
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2080
Support here is *optional*, as in it does *not* require even the GIR M4 macros to be available -- but then the generated build system can't generate GIR. This avoids a hard dependency on GIR for the cost of a configure-time conditional with basic fallback definitions.
As stated in the first commit, it's mostly ripped off Peasy, maybe there are additional change required, but it seems to mostly work. However, I see a lot of scary warnings like these:
```
…/doc/geany-sciwrappers-gtkdoc-tmp.h:25: syntax error, unexpected '*', expecting ')' or ',' in 'void scintilla_object__GI__MARK_set_text (ScintillaObject *sci, const gchar *text);' at '*'
…/doc/geany-sciwrappers-gtkdoc-tmp.h:25: syntax error, unexpected ')', expecting ',' or ';' in 'void scintilla_object__GI__MARK_set_text (ScintillaObject *sci, const gchar *text);' at ')'
…/doc/geany-sciwrappers-gtkdoc-tmp.h:43: syntax error, unexpected '*', expecting ')' or ',' in 'void scintilla_object__GI__MARK_start_undo_action (ScintillaObject *sci);' at '*'
…/doc/geany-sciwrappers-gtkdoc-tmp.h:64: syntax error, unexpected '*', expecting ')' or ',' in 'void scintilla_object__GI__MARK_end_undo_action (ScintillaObject *sci);' at '*'
…/doc/geany-sciwrappers-gtkdoc-tmp.h:84: syntax error, unexpected '*', expecting ')' or ',' in 'void scintilla_object__GI__MARK_set_marker_at_line (ScintillaObject *sci, gint line_number, gint marker);' at '*'
```
@codebrainz @kugel-
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1112
-- Commit Summary --
* Add support for building GIR
* Force enabling GObject-Introspection for distcheck
-- File Changes --
M Makefile.am (2)
M configure.ac (12)
M doc/Makefile.am (69)
-- Patch Links --
https://github.com/geany/geany/pull/1112.patchhttps://github.com/geany/geany/pull/1112.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1112
It would be nice to have and option in Preferences > Interface to support headerbar so that we:
a) gain some screen real state
b) make Geany look like a modern GTK3 app
It could be a simpler start where the window decoration top bar goes away and the menu and top icon bar (which are on the same 'line' in my geany configuration) move to the top border.
Or ideally a more thorough GUI refresh, maybe moving the Menu to a hamburger (but keeping the shortcuts to no change in day-to-day use to hardcore users), keeping the single-line icon bar, maybe coming up with a symbolic icon set (like GIMP did, for instance).
Sharing some thoughts. I use geany daily and it is starting to look a bit dated - it would be nice to have a visual refresh. The GTK3 port done a few years ago would probably enable this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2061
geany-1.34_setup.exe from https://download.geany.org/ is intalled to "C:\Program Files (x86)\Geany". It's a 32bit application. Please provide a 64 bit version for Windows.
Reason: 32bit exe can only use 4GB memory while 64 bit version exe does not have this limitation. 64 bit exe is useful when open large files, especially for an IDE.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2072
Hello Geany developers,
I have some questions about configuring auto-completion, may I ask if you could help?
1. Is there a setting to always show suggestion list (the popup menu)?
In docs, the menu does not pop up, unless I press for `Ctrl-space`. However I write docs a lot, so it would help me if the menu is shown. I tried to find, but couldn't find a setting.
2. The initial list does not always offer all phrases. Is there a setting to change that?
For example, I often have to press `Ctrl-space` _twice_, in order to show all phrases.
Thank you very much,
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2071