Closes #971, closes #1947.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2045
-- Commit Summary --
* Update Scintilla to version 3.10.2
-- File Changes --
M scintilla/gtk/ScintillaGTK.cxx (7)
M scintilla/gtk/ScintillaGTKAccessible.cxx (2)
M scintilla/include/Platform.h (5)
M scintilla/include/SciLexer.h (48)
M scintilla/include/Scintilla.h (14)
M scintilla/include/Scintilla.iface (90)
M scintilla/lexers/LexBash.cxx (279)
M scintilla/lexers/LexCPP.cxx (56)
M scintilla/lexers/LexFortran.cxx (8)
M scintilla/lexers/LexMarkdown.cxx (60)
M scintilla/lexers/LexVerilog.cxx (6)
M scintilla/lexlib/CharacterCategory.cxx (240)
M scintilla/lexlib/PropSetSimple.cxx (2)
M scintilla/scintilla_changes.patch (5)
M scintilla/src/CaseConvert.cxx (16)
M scintilla/src/Catalogue.cxx (4)
M scintilla/src/CellBuffer.cxx (349)
M scintilla/src/CellBuffer.h (10)
M scintilla/src/ContractionState.cxx (2)
M scintilla/src/Document.cxx (102)
M scintilla/src/Document.h (27)
M scintilla/src/EditModel.cxx (2)
M scintilla/src/EditView.cxx (2)
M scintilla/src/Editor.cxx (106)
M scintilla/src/Editor.h (2)
M scintilla/src/ExternalLexer.cxx (4)
M scintilla/src/Indicator.cxx (7)
M scintilla/src/KeyMap.cxx (4)
M scintilla/src/KeyMap.h (1)
M scintilla/src/PerLine.cxx (4)
M scintilla/src/PositionCache.cxx (7)
M scintilla/src/PositionCache.h (2)
M scintilla/src/RESearch.cxx (4)
M scintilla/src/RunStyles.cxx (6)
M scintilla/src/ScintillaBase.cxx (26)
M scintilla/src/Style.cxx (6)
M scintilla/src/UniConversion.cxx (16)
M scintilla/src/UniConversion.h (1)
M scintilla/src/ViewStyle.cxx (6)
M scintilla/version.txt (2)
-- Patch Links --
https://github.com/geany/geany/pull/2045.patchhttps://github.com/geany/geany/pull/2045.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2045
This is probably a bug in scintilla / ctags / whatever. Please forward appropriately.
Save the following as a normal file:
```
Hello [lovely
world](http://example.com/with/very/long/URL/that/cant/be/wrapped/reasonabl…
Asdf
```
Note that the line breaks are important. `Asdf` should be on the forth line.
Open this file in geany, move the cursor to the end of the line (right after the closing parenthesis that closes the link) and press 'return'. ('Enter' has the same effect.)
Expected behavior: a new line appears. Duh. (Nothing else should change.)
Actual behavior: a new line appears … and everything afterwards is also part of that link. At least that's what the syntax highlighting suddenly indicates. The whole rest of the file is affected; it doesn't reset at paragraph boundaries or any other sane "well no kind of formatting can cross this point anyway" border.
Manual workaround: find the "link" that caused all this, insert a character before it and delete it again. This seems to cause re-parsing of the link, and this time it works.
```
$ geany --version
geany 1.27 (git >= d1fcd9f) (kompiliert am 2016-01-03 mit GTK 2.24.29, GLib 2.46.2)
```
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/971
Minimal reproducing example:
This is displayed as normal text.
[ク](https://google.com)
This isn't.!
Steps to reproduce: Save it as `foo.md`, and open it in geany. Then delete the last exclamation mark to get around #971.
Expected behavior: Both normal text lines are displayed using the "normal text" style.
Actual behavior: The last line's style indicates that it is somehow still part of the link. Not visible in the short example: This affects the entire rest of the document.
Screenshot:
![Screenshot of the faulty behavior](https://user-images.githubusercontent.com/2690845/45174089-3b5a70…
Note that even before this "remove the last exclamation mark" step, one can see faulty behavior. Specifically, the `T` is styled wrong.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1947
Hi,
I'm currently using a custom file type configuration where I enabled the `DIFF` lexer which provides the best highlighting experience for this particular file syntax:
```
[styling=Diff]
comment=default
[settings]
lexer_filetype=Diff
```
Unfortunately, there is a highly demanded editor feature that cannot be used in this context: **stripping trailing spaces**.
By inspecting the source code, it's quite obvious the limitation is imposed by the `DIFF` lexer:
```
void editor_strip_line_trailing_spaces(GeanyEditor *editor, gint line)
{
[...]
/* Diff hunks should keep trailing spaces */
if (sci_get_lexer(editor->sci) == SCLEX_DIFF)
return;
[...]
}
```
I'm not sure if this is a bug or just a simple workaround to prevent corruptions of the `.patch` files.
I just want to use the `DIFF` syntax highlighting on files that do not have anything in common with the patch files, in particular by having the option to strip trailing spaces enabled permanently.
Does it make sense to improve the implementation by checking for `DIFF` file type instead of `DIFF` lexer?
Thank you!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2041
Geany is changing the group ownership of my file to the user owner when saved. This is only happening in Ubuntu 16.04 with a file over sftp.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2039
){kind=link}