Tested on Fedora 27 using stock Geany available from repo.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/645
-- Commit Summary --
* Ported 'Debugger' plugin to GTK+3.
-- File Changes --
M build/debugger.m4 (4)
M debugger/src/bptree.c (6)
M debugger/src/btnpanel.c (15)
M debugger/src/cell_renderers/cellrendererbreakicon.c (66)
M debugger/src/cell_renderers/cellrendererbreakicon.h (14)
M debugger/src/cell_renderers/cellrendererframeicon.c (57)
M debugger/src/cell_renderers/cellrendererframeicon.h (6)
M debugger/src/cell_renderers/cellrenderertoggle.c (9)
M debugger/src/dconfig.c (47)
M debugger/src/debug.c (43)
M debugger/src/dpaned.c (5)
M debugger/src/gui.c (2)
M debugger/src/plugin.c (2)
M debugger/src/stree.c (2)
M debugger/src/tpage.c (62)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/645.patchhttps://github.com/geany/geany-plugins/pull/645.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645
It is not valid to place `AM_CONDITIONAL`s inside a shell condition, because Automake has to known its value in all cases. Automake is smart enough to detect it if used in a AutoShell conditional (like `AS_IF`/`AS_CASE`/...), but can't work any magic inside a pure shell conditional (if/case/...). So, move the `AM_CONDITIONAL` outside the conditional, as the value is already conditional anyway.
This PR also cleans up the conditional a little bit by giving it a plugin-specific name, and removing irrelevant test fro the condition (whether or not the plugin is enabled has little to no relevance here, and the plugin won't be built anyway).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/787
-- Commit Summary --
* scope: Don't place AM_CONDITIONAL inside a shell condition
* scope: Use plugin-specific namespace for plugin-specific conditional
* scope: Cleanup conditional test
-- File Changes --
M build/scope.m4 (3)
M utils/src/Makefile.am (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/787.patchhttps://github.com/geany/geany-plugins/pull/787.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/787
An issue with italian translation:
When you are editing a file and someone else changes it on disk, you are presented a question: "Ricaricare il file?" ("Do you want to reload the file?"). The question is correct and the italian translation too.
But the 3 buttons on the right say: "Ripristina", "Sovrascrivere", "Annulla". There are various problems:
- For the 1st button, the use remains astonished, because he/she would have expected "Ricarica". A concentration effort is requested in order to understand whether "Ripristina" is the same as "Ricarica".
- The 2nd button has an infinitive, while the other two have a present tens: the 2nd button should go to present tens too.
Apparently those button names aren't in the code, because I can't see those words in the italian translation .po. So the code should be modified.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1999
Currently Geany, unlike other editors, is using double colons (::) as comment_single. What is the reason?
REM (with trailing space) is much more appropriate. A citation:
" REM is the standards-compliant, documented statement to insert comments in batch files;
double colons are a non-documented and non-compliant way to insert comments".
I will give two examples when using "::" is problematic.
First example:
IF 1 equ 1 (
:: Comment line 1
ECHO Do something
REM Comment line 2
:: Comment line 2
)
Here double colons give an error: ") was unexpected at this time."
Second example:
"C:\Program Files (x86)\WinSCP\WinSCP.com" ^
:: /log="%log_file%" ^
/command ^
"open %serverURL% -hostkey=* -privatekey=%keys%\%ppk% -rawsettings TryAgent=0 AuthKI=0" ^
"put ""%file_send%""" ^
"exit"
Because line continuation "^" is applicable to empty label (::), double colons here are commenting out all lines starting from the second to the very end, instead of commenting out only a single line.
I believe comment_single should be "comment_single=REM "
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1912
use treeview_position=800 move side bar to left
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1995
This pull request is heavily based on #645 from which it borrows the majority of the changes.
The main improvement is that this one doesn't break compatibility with GTK2 (there are macros which select the correct code path accordingly).
I also removed some cosmetic-only changes to maintain the differences as small as possible and provided a corrected code for console font selection (which was just commented out in the original pull request).
This was successfully tested on Centos 7.5 with stock development packages.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/790
-- Commit Summary --
* Ported the 'Debugger' plugin to GTK3 while maintaining compatibility with GTK2.
-- File Changes --
M build/debugger.m4 (5)
M debugger/src/btnpanel.c (25)
M debugger/src/cell_renderers/cellrendererbreakicon.c (73)
M debugger/src/cell_renderers/cellrendererbreakicon.h (11)
M debugger/src/cell_renderers/cellrendererframeicon.c (62)
M debugger/src/cell_renderers/cellrendererframeicon.h (7)
M debugger/src/cell_renderers/cellrenderertoggle.c (9)
M debugger/src/dconfig.c (68)
M debugger/src/debug.c (49)
M debugger/src/dpaned.c (6)
M debugger/src/gui.c (4)
M debugger/src/plugin.c (4)
M debugger/src/stree.c (4)
M debugger/src/tpage.c (84)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/790.patchhttps://github.com/geany/geany-plugins/pull/790.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/790
