As discussed in https://github.com/geany/geany/pull/1180.
This change adds two new functions: `document_rename_file_and_save()`, and `document_rename_and_save()`. `document_rename_file_and_save()` is kind of like the combination of `document_rename_file()` and `document_save_file_as()`, and is strictly about renaming the associated file, and doing the stuff necessary before and after the file has been renamed, like disabling file monitoring, and putting it back if a rename fails, saving/restoring file disk status, etc.
`document_rename_and_save()` OTOH is more of a wrapper, and is about renaming the document itself. It doesn't require the document to have an associated file to it (i.e. `doc->real_path != NULL`). But if there is an associated file, the file is also renamed, i.e., `document_rename_file_and_save()` is called. The algorithm to check if the file has to be overwritten is also contained in it. This function should be adaptable to other implementations like [in-place renaming](https://github.com/konsolebox/geany/tree/docs_rename).
In `dialogs.c`, stuff about resetting `doc->tm_file` and calling `build_menu_update()` has been moved to `document_save_file_as()`, since both are essentially needed to be done by anyone that calls the function. It helps significantly simplify the two new functions and the functions in `dialogs.c`.
The function `save_as_dialog_handle_response()` has been refactored, and is now simpler since the "overwrite file?" prompt has been moved to `document_rename_and_save()`, and since it can now directly call `document_rename_and_save()` and `document_save_file_as()`. `dialogs_show_save_as()` now also directly calls `document_save_file_as()` if `interface_prefs.use_native_windows_dialogs == TRUE`. `handle_save_as()` is no longer needed, so it's been removed.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1194
-- Commit Summary --
* Add document_rename_file_and_save()
* Do not make document_rename_file_and_save() an API function for now
* Add document_rename_and_save()
* Move resetting GeanyDocument::tm_file, and calling build_menu_update() to document_save_file_as()
* Rework Save-As functions in dialogs.c
* dialogs_show_save_as: g_free(utf8_name);
-- File Changes --
M src/dialogs.c (78)
M src/document.c (81)
M src/document.h (4)
-- Patch Links --
https://github.com/geany/geany/pull/1194.patchhttps://github.com/geany/geany/pull/1194.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1194
Zooming itself is fine, it works if "zoom in(out)" menu items are clicked. Default zooming hotkeys (which are written on these menu items) do not have any effect.
Geany 1.32, macOS 10.12.6
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1712
I think, when commenting Python code via `Edit` > `Format` > `Comment Line(s)`, after the `#` character would be better to add a space, [as mentioned in PEP8](https://www.python.org/dev/peps/pep-0008/#block-comments), resulting:
<code>
# commented line
</code>
instead of:
<code>
#commented line
</code>
This prevent me to manual adjust (all) the commented line(s).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1681
I can reliably crash Geany 1.33 (and previous versions) by the following commands.
1. "File->Open" (or any other method) to display the open file dialog.
2. Shift+RightClick on a directory, and select "Copy as Path".
3. Wait. A crash will occur.
Note: the crash occurs sooner if you paste the copied path anywhere, for instance into the open "untitled" window, or where I first encountered the crash: open a cmd window, enter "cd /d " and paste the copied path.
The event viewer displays "Event 1000, Application Error" and the following info:
`Faulting application name: geany.exe, version: 1.33.0.0, time stamp: 0x00000000`
`Faulting module name: libgdk-win32-2.0-0.dll, version: 2.24.32.0, time stamp: 0x00000000`
`Exception code: 0xc0000005`
`Fault offset: 0x00026472`
`Faulting process id: 0x18f0`
`Faulting application start time: 0x01d44284f527cbc7`
`Faulting application path: C:\Program Files (x86)\Geany\bin\geany.exe`
`Faulting module path: C:\Program Files (x86)\Geany\bin\libgdk-win32-2.0-0.dll`
`Report Id: 056c8fd0-6756-4c2a-a813-32ce3f030269`
`Faulting package full name: `
`Faulting package-relative application ID:`
systeminfo displays the following:
`OS Name: Microsoft Windows 10 Home`
`OS Version: 10.0.17134 N/A Build 17134`
`OS Manufacturer: Microsoft Corporation`
`OS Configuration: Standalone Workstation`
`OS Build Type: Multiprocessor Free`
My WAG is that this relates to the allocation, permissions, or ownership of the paste buffer.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1942
Preview documents written in various markup languages.
* Supports: Markdown, reStructuredText, Txt2tags, LaTeX, Docbook, Asciidoc, Textile, org-mode, and RFC-822-like messages
* May be used as a rudimentary web browser
* Can toggle visibility of menubar and tab close buttons
* Requires geanypy, pandoc, and asciidoc
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/489
-- Commit Summary --
* new plugin: geanypy-preview
-- File Changes --
A geanypy-preview/AUTHORS (1)
A geanypy-preview/CHANGELOG (33)
A geanypy-preview/COPYING (339)
A geanypy-preview/README.md (93)
A geanypy-preview/preview.py (741)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/489.patchhttps://github.com/geany/geany-plugins/pull/489.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/489
find -L . -not -path '*/\.*' | ctags --totals --fields=fKsSt --extra=-fq --c-kinds=+p --sort=foldcase --excmd=number -L - -f /home/v/compile/2048 NG/2048 NG.tags (в каталоге: /home/v/compile/2048 NG/)
ctags: Warning: cannot open source file "NG/2048" : No such file or directory
ctags: Warning: cannot open source file "NG.tags" : No such file or directory
ctags: Warning: ignoring null tag in ./cocos2d/templates/js-template-default/res/loading.js
ctags: Warning: ignoring null tag in ./cocos2d/tests/js-tests/src/Presentation/Presentation.js
ctags: Warning: ignoring null tag in ./cocos2d/web/template/res/loading.js
ctags: Warning: ignoring null tag in ./cocos2d/web/CCBoot.js
ctags: Warning: ignoring null tag in ./cocos2d/web/cocos2d/labels/CCLabelAtlasCanvasRenderCmd.js
ctags: Warning: ignoring null tag in ./cocos2d/web/cocos2d/core/utils/BinaryLoader.js
ctags: Warning: ignoring null tag in ./cocos2d/cocos/scripting/js-bindings/script/ccui/jsb_ccui_deprecated.js
ctags: Warning: ignoring null tag in ./cocos2d/cocos/scripting/js-bindings/script/debugger/actors/webconsole.js
ctags: Warning: ignoring null tag in ./cocos2d/cocos/scripting/js-bindings/script/jsb_boot.js
ctags: Warning: ignoring null tag in ./cocos2d
So we have to single-quote `/home/v/compile/2048 NG/2048 NG.tags`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/738
When I reboot the system - geany loses the list of open files, how to fix it?
System Kubuntu 12, and 14, and 16 - The same behavior.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1826
When shutting down the OS while geany is open, geany closes but does not remember the open tabs like it does when the user closes geany normally.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1416