Currently the foreground colors of all colored lines in the message window are hardcoded in the get_color function in msgwindow.c. This works fine on white background, but with a dark GTK-theme the compiler error messages are barely readable. Would it be possible to make these colors configurable in the colorscheme?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1376
```
../../src/build.c: In function ‘build_load_menu_grp’:
../../src/build.c:2271:19: warning: ‘__builtin___sprintf_chk’ may write a terminating nul past the end of the destination [-Wformat-overflow=]
sprintf(cmdbuf, "%02u", cmd);
^~~~~~
In file included from /usr/include/stdio.h:862:0,
from ../../src/tagmanager/tm_source_file.h:13,
from ../../src/tagmanager/tm_tag.h:32,
from ../../src/app.h:31,
from ../../src/build.c:35:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: ‘__builtin___sprintf_chk’ output between 3 and 4 bytes into a destination of size 3
return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__bos (__s), __fmt, __va_arg_pack ());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
I believe this to be a false positive as the affected code is explicitly guarded to prevent said overflow. The new warning is [described a bit here](https://gcc.gnu.org/gcc-7/changes.html).
Making the buffer one byte larger works around the warning.
My version: gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1683
Noticed with GCC 7 using `-Wall -Wextra -Wno-unused-parameter` warning options.
There's still a warning in `scintilla/src/Editor.cxx:205` but I left that for upstream to fix.
For some reason the warning mentioned in Issue #1683 doesn't occur anymore here, so I didn't fix it.
It would be great if someone could double-check the switch case fall-through changes to ensure I didn't actually mask real bugs, and that the bug I fixed in `keybindings.c` was actually correct.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1725
-- Commit Summary --
* Fix pointer and character constant comparison
* Fix comparison between signed and unsigned integers
* Fix missing initializer for field warnings
* Fix missing initializer for field warnings in parsers
* Adjust 'fall through' comments to be recognized by GCC
* Add more 'fall through' comments for switch cases
* Remove some unused variables
* Fix comparison between signed and unsigned integers
* Add 'fall through' comments and fix actual bug
-- File Changes --
M ctags/main/parse.c (4)
M ctags/main/xtag.c (10)
M ctags/parsers/actionscript.c (20)
M ctags/parsers/cobol.c (12)
M ctags/parsers/fortran.c (4)
M ctags/parsers/html.c (10)
M ctags/parsers/perl.c (2)
M ctags/parsers/r.c (1)
M src/editor.c (7)
M src/encodings.c (4)
M src/highlighting.c (3)
M src/keybindings.c (2)
M src/search.c (1)
M src/tools.c (1)
-- Patch Links --
https://github.com/geany/geany/pull/1725.patchhttps://github.com/geany/geany/pull/1725.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1725
If the item "Context Action" is selected from the context menu then nothing happens if no action is configured for the current filetype.
It would be more user friendly if a little message window pops up, pointing to the corresponding section in the geany manual.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1641
I see this came up previously is issue #842 , and although .edn is a general-purpose data format, it's also a subset of Clojure and is essentially just Clojure data structures. .edn files should be syntax highlighted as Clojure.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1724
With GTK+ 3 and certain, even default, themes, the notebook tabs are so massive as to not allow more than one tab visible at a time in certain notebooks like the sidebar and message window. This just sets the `enable-popup` property of those notebooks to true to give an alternative way to quickly change the current tab.
Related somewhat to #1718 and #1723.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1726
-- Commit Summary --
* Enable popup menu on sidebar and message window notebooks
-- File Changes --
M data/geany.glade (4)
-- Patch Links --
https://github.com/geany/geany/pull/1726.patchhttps://github.com/geany/geany/pull/1726.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1726
i only have a screenshot of the problem, but i think it speaks for itself. can you help me create some printable output regarding this? just a geany user not a developer.
[http://i.imgur.com/YbRCJ8g.png](url)
geany verison: 1.29
OS: debian 9.1
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1583
Fix the symbols tree hierarchy by considering the whole scope when adding a tag, avoiding choosing the wrong parent when several tags have the same name. Until now, to avoid such misbehavior we only used to choose the parent candidate that appeared last (line-wise) before the child. It works in most typical situations as generally tag names are fairly unique, and children appear right after their parent.
However, there are cases that are trickier and cannot be handled that way. In the following valid C++ snippet, it is impossible to know whether `function` should be listed under the namespace `A` or the
class `A` without looking at its full scope:
```C++
namespace A {
namespace B {
class A {
void method() {}
};
};
void function() {}
};
```
And it is a real-world problem for some parsers like the JSON parser that generates numeric indices for array elements name, often leading to several possibly close duplicates.
Additionally, to prevent trying to set a tag as its own parent, the code guarded against accepting a parent if the child had the same name, lading to incorrect hierarchy for `method` in cases like this:
```C++
namespace A {
class A {
void method() {}
};
};
```
So to fix this, consider the whole hierarchy of a tag for choosing its parent, when that information is available from the parser.
Fixes #1583.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1598
-- Commit Summary --
* Fix the symbols tree hierarchy when several tags have the same name
-- File Changes --
M HACKING (6)
M src/symbols.c (78)
M src/tagmanager/tm_tag.c (41)
M src/tagmanager/tm_tag.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/1598.patchhttps://github.com/geany/geany/pull/1598.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1598
](http://i.imgur.com/YbRCJ8g.png](url)){kind=link}