> But we still need a proper thing here, either implementing it somehow, or dropping the feature altogether (I'd vote for the second, but well).
If we can just guard out the feature for unsupported versions, that would be cool. Anyone who wants support with VTE that doesn't natively support the feature anymore can give patches to VTE project or else try and get a "workaround" PR merged into Geany.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240896036
https://github.com/b4n/geany/commits/vte-2.91 seems to work, but for background images. I can't seem to find a non-crazy way of implementing it (I can't get CSS to do it), and I don't care enough about it to implement a crazy way. But we still need a proper thing here, either implementing it somehow, or dropping the feature altogether (I'd vote for the second, but well).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240895063
> We're also running on very limited developer resources. Every minute spent on maintaining the GTK2 version would have been taken away from making the GTK3 version better, effectively resulting in the world having a significantly worse GTK3-based VTE today. I'm absolutely convinced ditching GTK2 support was the best we could do.
Pity about the projects using it, now they all have to spend the effort to update.
@b4n, just take VTE out of Geany until it gets its shit together, simple solution.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240879059
> 0.44 ones have it, but lost the description
Thanks, filed https://bugzilla.gnome.org/show_bug.cgi?id=770114. For the time being, you can consult the docs next to the methods in the source code.
Feel free to file any further bugs you encounter to our bugtracker!
> Though I wish they continued on a GTK2-compatible version
We're also running on very limited developer resources. Every minute spent on maintaining the GTK2 version would have been taken away from making the GTK3 version better, effectively resulting in the world having a significantly worse GTK3-based VTE today. I'm absolutely convinced ditching GTK2 support was the best we could do.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240860246
> The doc is designed for people writing new code against VTE […]
Ok, mostly makes sense.
On this topic though, the docs are somewhat broken. See for example [the 0.38 docs for `vte_terminal_set_color_foreground()`](https://developer.gnome.org/vte/0.38/VteTerminal.html#vte-terminal-set-color-foreground): it doesn't have the proper prototype. [0.44 ones](https://developer.gnome.org/vte/0.44/VteTerminal.html#vte-terminal-se… have it, but lost the description.
> Plus, the aforementioned users, although suffer from the inconvenience of having to install another lib, will get the new features, bufixes, security/privacy fixes (e.g. scrollback buffer no longer written plaintext to disk) of new vte.
That only depends on us supporting the newer API and the user having that newer lib. The only advantage of dropping 2.90 support would be for users to get no VTE support and complain, then tell them to install 2.91, instead of them not seeing they miss 2.91 but have 2.90. Nah, we're not babysitters, they can do it.
And yeah, I myself don't care support for older systems, I use a recent one. But we always have kept support for older systems whenever it wasn't too crazy, and I won't change that just for VTE 0.38.
> As a VTE developer, I see no reason in supporting both versions in parallel […]
The VTE developers surely won't want to support 2.90 anymore, that's fairly understandable. Though I wish they continued on a GTK2-compatible version, but well :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240855696
> because the 0.38 docs lacks any "new in 0.38" docs, so it has to be guessed
The doc is designed for people writing new code against VTE, not for those porting their code from older versions. As such, it solely documents the 2.91 API, and therefore only mentions additions that weren't yet available in the very first 2.91 version (that is, things you need to be aware of if developing against 2.91). In other words, on a backwards incompatible API bump the doc is started over from scratch. With this regard, it's absolutely irrelevant when something appeared and how (if differently) looked like in the previous API. (I do not intend to discuss whether it's good or bad this way, I just stated that this is the reason. I think it's the same with, let's say, GTK+ version 3, you won't see any GTK+-2 stuff or 2->3 porting advice mentioned in GTK+-3's docs.)
> No. Unless there's a compelling reason to drop 2.90, we should not drop it.
Con of dropping: Save one step for users who have an old enough system not to have libvte 2.91, however, wish to have the latest Geany with as little hassle as possible. (I never quite understood this goal, I believe those wishing to run the latest apps are expected to keep their base system reasonably up to date as well. Sure it's nice to have some window, but maybe 2 years should be enough.)
Pros of dropping: Cleaner, simpler code, easier maintenance, fewer setups to test. Plus, the aforementioned users, although suffer from the inconvenience of having to install another lib, will get the new features, bufixes, security/privacy fixes (e.g. scrollback buffer no longer written plaintext to disk) of new vte.
As a VTE developer, I see no reason in supporting both versions in parallel, I pretty much find it a waste of the precious (and apparently scarce) developer resources. However, your project, your call.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240853182
> The first stable version with the new API was released almost 2 years ago. I have myself ported a vte-based terminal emulator (whose codebase I was not familiar with), it took maybe like 2-3 hours, can't remember, but definitely not much more.
The problem is that for some reason we `dlopen()` VTE, and 0.38 lacks runtime version checking, so it's harder than it should. But yeah maybe we could play and assume it's 0.38 if an older symbol is missing and a newer present (although it's made even more annoying to do than it should because the [0.38 docs](https://developer.gnome.org/vte/0.38/) lacks any "new in 0.38" docs, so it has to be guessed).
It'd probably be doable, but VTe really doesn't help here.
> (I don't think parallel support for 2.90 and 2.91 makes any sense, just go for 2.91 and forget 2.90 for good).
No. Unless there's a compelling reason to drop 2.90, we should not drop it.
> A note about `vte_terminal_set_background_image_file()`: Indeed direct support for background image has been removed; however, see the Terminix project how a picture can be drawn behind a transparent/translucent VTE using some GTK+ magic.
Probably makes sense. But well, it's a retarded feature anyway, so why bother.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240843725
FYI: Debian and Ubuntu have already dropped libvte 2.90 (tarball 0.36). They only ship the ancient gtk2 version (tarball 0.28), as well as 2.91 for gtk3 (tarball 0.38 or newer).
Neither the gtk2 version, nor 2.90 is maintained anymore by upstream. Bugfixes / security fixes / improvements only go to the newest tarballs (library version 2.91).
The first version with the new API was released almost 2 years ago. I have myself ported a vte-based terminal emulator (whose codebase I was not familiar with), it took maybe like 2-3 hours, can't remember, but definitely not much more.
So I guess it's high time port geany to the newest vte. (I don't think parallel support for 2.90 and 2.91 makes any sense, just go for 2.91 and forget 2.90 for good).
A note about `vte_terminal_set_background_image_file()`: Indeed direct support for background image has been removed; however, see the Terminix project how a picture can be drawn behind a transparent/translucent VTE using some GTK+ magic.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240840936
No. Maybe the latest version could be usable, I'd have to check. For the moment just use 2.90.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/336#issuecomment-240829459