Also adding `update_menu` arg to `ui_statusbar_showhide` function, to fix "Toggle All Additional Widgets" problem and cleaner code
We should do the same for Sidebar too (adding `gboolean update_menu` to `ui_sidebar_show_hide` function), because when you click "Toggle All Additional Widgets" , the menu item (View -> Show Sidebar) is not checked
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/986
-- Commit Summary --
* add View -> Show Statusbar check menu item, plus key binding to show/hide statusbar
-- File Changes --
M data/geany.glade (10)
M src/callbacks.c (11)
M src/callbacks.h (2)
M src/keybindings.c (5)
M src/keybindings.h (1)
M src/libmain.c (7)
M src/prefs.c (5)
M src/ui_utils.c (21)
M src/ui_utils.h (4)
-- Patch Links --
https://github.com/geany/geany/pull/986.patchhttps://github.com/geany/geany/pull/986.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/986
glib 2.32 is 6 years old and part of the now out-of-lts Ubuntu 12.04 so I'm thinking it should be safe. But if you think otherwise let me know.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/c9f291ae4015a3bb8d6ea142b1beb6c9fcc43…
We don't use it directly, we only have it to re-generate Scintilla marshallers. But calling it shouldn't be a problem, and I was planning to see whether we shouldn't simply generate our own version of Scintilla's ones so we don't ever fall back to a situation where theirs are outdated (although it shouldn't happen too often).
Anyway, if we need `G_TYPE_KEY_FILE` we need 2.32, so I guess it doesn't matter.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/c9f291ae4015a3bb8d6ea142b1beb6c9fcc43…
We don't use glib-genmarshal currentlly, do we? I can certainly take a look at that if bumping the glib requirement is a problem (I didn't see it'd raise the minimum until recently).
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/c9f291ae4015a3bb8d6ea142b1beb6c9fcc43…
why not use our own marshallers and generate them with genmarshal? no bump, easy, and I don't see no downside
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/c9f291ae4015a3bb8d6ea142b1beb6c9fcc43…
Line dialogs.c:1347 says "/* For a cancel button, use cancel response so user can press escape to cancel */" however in line 1357 only GTK_RESPONSE_CANCEL is linked to response_2, but esc KEY triggers a GTK_RESPONSE_DELETE_EVEN; hence it should be included also in 1357.
I found it because of a strange behaviour when cancelling a keybinding override in preferences dialog. You can reproduce it like so: go to prefs>keybindings, set a keybinding which is already used for another command, then Geany will show up a dialog saying that the combination is already used. Once there, if you press <kbd>Esc</kbd> key, you'll see that it does the "Allow" action, instead of -what the user would expect- the "Cancel" action.
I'm testing it and dialogs work fine as well as the issue exposed above is fixed.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/714
-- Commit Summary --
* Set close dialog and esc key events as cancel in show_prompt()
-- File Changes --
M src/dialogs.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/714.patchhttps://github.com/geany/geany/pull/714.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/714
I always use the long line marker, and I like to keep it in low contrast in respect to the background. However, everytime I switch from a dark them to a light theme I always have to change it manually.
I don't know if this bothers someone else too, so I understand if this is not really your priority.
Thank you
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1030
Try and remove special casing of built-in tags files, by making them normal tags files named appropriately and following the format (*html_entities.tags* didn't).
This might require a little further testing, but it seems to work just as expected, and removes the startup warnings about those tags files' name (introduced by 3640b3bc4461f302cc2375e4998c58f7729493eb AFAICT):
```
Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/html_entities.tags'.
Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/pascal.tags'.
Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/c99.tags'.
Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/python.tags'.
Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/php.tags'.
```
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1014
-- Commit Summary --
* Make html_entities.tags a real tags file
* Don't special-case tags files distributed with Geany
-- File Changes --
M data/Makefile.am (10)
R data/tags/entities.html.tags (3)
R data/tags/std.pas.tags (0)
R data/tags/std.php.tags (0)
R data/tags/std.py.tags (0)
R data/tags/std99.c.tags (0)
M src/editor.c (48)
M src/symbols.c (93)
M src/symbols.h (2)
M src/utils.c (19)
M src/utils.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/1014.patchhttps://github.com/geany/geany/pull/1014.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1014
Geany Version: 1.27
GTK+ Version: 2.24.28 (packaged with the full installer)
OS Version: Windows 10 x86_64
Whenever I try to type quotes and double quotes in the editor or in any text box with the US international keyboard mapping, instead of getting " or ', I get ¨ and ´ respectively.
That issue is not present if I use my "native" keyboard mapping (french azerty) or the simple US qwerty)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1036
Currently the special characters are hard coded inside code. It would be a good point to have it dynamic and configurable/extensible via a file.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/430