The brackets are apparently wrong - the check that should happen is
strcmp(text, "2147483648") < 0
but instead the whole expression
(s - text == 10 && strcmp(text, "2147483648"))
is compared if it's less than zero.
Noticed by LLVM:
utils.c:654:50: warning: comparison of constant 0 with boolean expression is always false
[-Wtautological-constant-out-of-range-compare]
(s - text == 10 && strcmp(text, "2147483648")) < 0) ? text : NULL;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/419
-- Commit Summary --
* scope: Fix validate_number()
-- File Changes --
M scope/src/utils.c (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/419.patchhttps://github.com/geany/geany-plugins/pull/419.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/419
This is hopefully the last "big" patch set related to TM. In fact, despite the diff size, it's actually not that big - the diffs are mostly caused by moving stuff around.
There are no functional changes in this patch set - just cleanups.
Most of the patches concentrate on TM<-->ctags interaction and simplification of their interfaces.
The last patch is an API/ABI break affecting projectorganizer and geanyprj - probably not worth the break alone but if there are more patches requiring ABI break, this one could be added. Can remove it from this patch set and submit separately.
It would be nice to have it applied early-ish in the 1.28 cycle as I'd like to do some work on syncing with upstream universal-ctags which will depend on these patches.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/957
-- Commit Summary --
* Remove the TagEntrySetArglistFunction hook
* Initialize ctags at a single place instead of four
* Improve ctags callback API
* Use G_BEGIN_DECLS/G_END_DECLS
* Remove unused tm_tagmanager.h
* Move code related to various tag file formats into tm_source_file.c
* Add an API-like ctags layer
* Use TMParserType instead of language name in tm_source_file_new()
* Clean up messy tm_workspace_create_global_tags()
* Remove some unused return values and unnecessary checks
-- File Changes --
M src/document.c (5)
M tagmanager/ctags/entry.c (8)
M tagmanager/ctags/entry.h (1)
M tagmanager/ctags/parse.c (9)
M tagmanager/ctags/parse.h (7)
M tagmanager/ctags/python.c (30)
M tagmanager/src/Makefile.am (6)
A tagmanager/src/tm_ctags_wrappers.c (113)
A tagmanager/src/tm_ctags_wrappers.h (47)
M tagmanager/src/tm_source_file.c (806)
M tagmanager/src/tm_source_file.h (24)
M tagmanager/src/tm_tag.c (559)
M tagmanager/src/tm_tag.h (38)
D tagmanager/src/tm_tagmanager.h (39)
M tagmanager/src/tm_workspace.c (373)
M tagmanager/src/tm_workspace.h (9)
M wscript (1)
-- Patch Links --
https://github.com/geany/geany/pull/957.patchhttps://github.com/geany/geany/pull/957.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/957
Buffered draw seems to be faster and with newer Gtk versions
works correctly on HiDPI screens.
I haven't checked precisely since which Gtk version this works
(didn't work in 3.10, might have been fixed in a later version)
but it isn't as important because even with 3.16 the build
is highly unstable because of Gtk issues (Gtk 3.18 seems to
be promising though).
I don't plan using Gtk 3 for the OS X 1.27 release so this patch can be applied later.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/946
-- Commit Summary --
* Enable buffered draw on newer Gtk versions on OS X
-- File Changes --
M src/editor.c (5)
-- Patch Links --
https://github.com/geany/geany/pull/946.patchhttps://github.com/geany/geany/pull/946.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/946
The extension is used by both C and C++ and lexing/parsing C headers with
the C++ parser causes less problems (identifiers named like C++ keywords
get highlighted and tags aren't generated for them) than parsing C++
headers with the C parser (parsing and lexing completely broken).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/857
-- Commit Summary --
* Treat the "h" extension as a C++ file
-- File Changes --
M data/filetype_extensions.conf (2)
-- Patch Links --
https://github.com/geany/geany/pull/857.patchhttps://github.com/geany/geany/pull/857.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/857