Quickly tested
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/364
-- Commit Summary --
* pretty-printer: Fix memory leak on reallocation error
* pretty-printer: Switch to the GLib allocator
* pretty-printer: Fix huge memory leak
* pretty-printer: Separate the input and output arguments
* pretty-printer: Drop use of the most obvious deprecated Geany API
* pretty-printer: Don't needlessly duplicated the document contents
-- File Changes --
M pretty-printer/src/PluginEntry.c (29)
M pretty-printer/src/PrettyPrinter.c (42)
M pretty-printer/src/PrettyPrinter.h (4)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/364.patchhttps://github.com/geany/geany-plugins/pull/364.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/364
21:38:28: Geany INFO : Geany 1.27 (git >= 27628c0), en_AU.UTF-8
21:38:28: Geany INFO : GTK 3.10.8, GLib 2.40.2
latest git d1fcd9f with the @b4n pr #852
Saved a new file to home directory the tab text changed from red to black and geany just hung, no UI response. Unfortunately it went away just as I attached gdb :(
I also have had a previous hang in the last few days, again I think just after a new file save but didn't pay much attention then, paid more attention the second time it happened. The first hang was before #852 so I think that is unlikely to be the culprit.
This doesn't seem to be related to previously reported "hangs" "crashes" or "freezes" which seem to be dodgy filesystems or similar or MS windows. This is Linux Mint 17.3 (based on Ubuntu LTS) on a local disk and no error messages in the logs, and the file saved fine.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/853
Line dialogs.c:1347 says "/* For a cancel button, use cancel response so user can press escape to cancel */" however in line 1357 only GTK_RESPONSE_CANCEL is linked to response_2, but esc KEY triggers a GTK_RESPONSE_DELETE_EVEN; hence it should be included also in 1357.
I found it because of a strange behaviour when cancelling a keybinding override in preferences dialog. You can reproduce it like so: go to prefs>keybindings, set a keybinding which is already used for another command, then Geany will show up a dialog saying that the combination is already used. Once there, if you press <kbd>Esc</kbd> key, you'll see that it does the "Allow" action, instead of -what the user would expect- the "Cancel" action.
I'm testing it and dialogs work fine as well as the issue exposed above is fixed.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/714
-- Commit Summary --
* Set close dialog and esc key events as cancel in show_prompt()
-- File Changes --
M src/dialogs.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/714.patchhttps://github.com/geany/geany/pull/714.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/714